components/password_manager/core/browser/password_manager.h - Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification

Patch Set: replaced " DCHECK(client_->IsSavingAndFillingEnabledForCurrentPage()) Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.h

diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h

index 761fbbcda9863d3abfc1d5668804dca8d817a7c4..1a2764271f58330eaff9298c335e7fd126316479 100644

--- a/components/password_manager/core/browser/password_manager.h

+++ b/components/password_manager/core/browser/password_manager.h

@@ -115,6 +115,11 @@ class PasswordManager : public LoginModel {

const base::string16& generation_element,

bool is_manually_triggered);

+ // Saves the outcome of HTML parsing based form classifier to uploaded proto.

+ void SaveGenerationFieldDetectedByClassifier(

+ const autofill::PasswordForm& form,

+ const base::string16& generation_field);

// TODO(isherman): This should not be public, but is currently being used by

// the LoginPrompt code.

// When a form is submitted, we prepare to save the password but wait