Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification
Patch Set: replaced " DCHECK(client_->IsSavingAndFillingEnabledForCurrentPage()) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc
index c53e176a546787f10adde0c659cd0e12b90604e2..15b406fe697257d5f84b531c173572c5526bffb2 100644
--- a/components/password_manager/content/browser/content_password_manager_driver.cc
+++ b/components/password_manager/content/browser/content_password_manager_driver.cc
@@ -162,6 +162,8 @@ bool ContentPasswordManagerDriver::HandleMessage(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(AutofillHostMsg_InPageNavigation, OnInPageNavigation)
IPC_MESSAGE_HANDLER(AutofillHostMsg_PresaveGeneratedPassword,
OnPresaveGeneratedPassword)
+ IPC_MESSAGE_HANDLER(AutofillHostMsg_SaveGenerationFieldDetectedByClassifier,
+ OnSaveGenerationFieldDetectedByClassifier)
IPC_MESSAGE_HANDLER(AutofillHostMsg_PasswordNoLongerGenerated,
OnPasswordNoLongerGenerated)
IPC_MESSAGE_HANDLER(AutofillHostMsg_FocusedPasswordFormFound,
@@ -261,6 +263,18 @@ void ContentPasswordManagerDriver::OnPasswordNoLongerGenerated(
false);
}
+void ContentPasswordManagerDriver::OnSaveGenerationFieldDetectedByClassifier(
+ const autofill::PasswordForm& password_form,
+ const base::string16& generation_field) {
+ if (!CheckChildProcessSecurityPolicy(
+ password_form.origin,
+ BadMessageReason::
+ CPMD_BAD_ORIGIN_SAVE_GENERATION_FIELD_DETECTED_BY_CLASSIFIER))
+ return;
+ GetPasswordManager()->SaveGenerationFieldDetectedByClassifier(
+ password_form, generation_field);
+}
+
bool ContentPasswordManagerDriver::CheckChildProcessSecurityPolicy(
const GURL& url,
BadMessageReason reason) {

Powered by Google App Engine
This is Rietveld 408576698