components/autofill/content/common/autofill_messages.h - Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 2055633003: [Password Generation] Sends form classifier vote to autofill server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pg_form_classification

Patch Set: Changed enum values Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_generation_agent.h » ('j') | components/autofill/content/renderer/password_generation_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 397cb5ffbaa24e1c233744d8a9a4637fce50a335..60a845ab537171d62b3afdb03047aa58b5f8497b 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -207,6 +207,12 @@ IPC_MESSAGE_ROUTED1(

AutofillMsg_FoundFormsEligibleForGeneration,

std::vector<autofill::PasswordFormGenerationData> /* forms */)

+// Sends the outcome of HTML parsing based form classifier to be saved in

+// uploaded protobuf.

dvadym 2016/06/16 10:04:38 You shouldn't write what will be done with informa

kolos1 2016/06/16 13:28:44 Done.

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_SaveFormClassifierVote,

dvadym 2016/06/16 10:04:38 Name of this message should say something about ge

dvadym 2016/06/16 10:04:38 Please move this message to Renderer->Browser mess

kolos1 2016/06/16 13:28:44 Done.

+ autofill::PasswordForm,

+ base::string16 /* generation field */)

// Sent when Autofill manager gets the query response from the Autofill server

// which contains information about username and password fields for some forms.

// |predictions| maps forms to their username fields.