[Password Generation] Sends form classifier vote to autofill server

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 189 matching lines @@
 // be blacklisted if a user chooses "never save passwords for this site".
 IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
                     autofill::PasswordForm /* form checked */)
 
 // Sent when Autofill manager gets the query response from the Autofill server
 // and there are fields classified for password generation in the response.
 IPC_MESSAGE_ROUTED1(
     AutofillMsg_FoundFormsEligibleForGeneration,
     std::vector<autofill::PasswordFormGenerationData> /* forms */)
 
+// Sends the outcome of HTML parsing based form classifier to be saved in
+// uploaded protobuf.

[dvadym, 2016/06/16 10:04:38]

You shouldn't write what will be done with information of this message in
browser. It's not high level enough here, and it can be changed in future.

[kolos1, 2016/06/16 13:28:44]

Done.

+IPC_MESSAGE_ROUTED2(AutofillHostMsg_SaveFormClassifierVote,

[dvadym, 2016/06/16 10:04:38]

Name of this message should say something about generation and/or password
forms. It's not clear that this is outcome of Password form classifier, in
password code it's ok, but here it's common for password and autofill code.

[dvadym, 2016/06/16 10:04:38]

Please move this message to Renderer->Browser messages 

[kolos1, 2016/06/16 13:28:44]

Done.

[kolos1, 2016/06/16 13:28:44]

Done.

+                    autofill::PasswordForm,
+                    base::string16 /* generation field */)
+
 // Sent when Autofill manager gets the query response from the Autofill server
 // which contains information about username and password fields for some forms.
 // |predictions| maps forms to their username fields.
 IPC_MESSAGE_ROUTED1(AutofillMsg_AutofillUsernameAndPasswordDataReceived,
                     FormsPredictionsMap /* predictions */)
 
 // Autofill messages sent from the renderer to the browser.
 
 // TODO(creis): check in the browser that the renderer actually has permission
 // for the URL to avoid compromised renderers talking to the browser.
@@ skipping 127 matching lines @@
 // Inform browser of data list values for the curent field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList,
                     std::vector<base::string16> /* values */,
                     std::vector<base::string16> /* labels */)
 
 // Inform the browser which password form is currently focused, as a response
 // to the |AutofillMsg_FindFocusedPasswordForm| request. If no password form
 // is focused, the response will contain an empty |autofill::PasswordForm|.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_FocusedPasswordFormFound,
                     autofill::PasswordForm)