Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 205563004: Revert of Implement /content/ combinator. (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Revert of Implement /content/ combinator. (https://codereview.chromium.org/187353003/) Reason for revert: Shadow DOM styling spec was changed. /content/ was reverted in the spec. Original issue's description: > Implement /content/ combinator. > > spec: shadow styling > http://dev.w3.org/csswg/shadow-styling/#content-combinator > > The added layout tests are basically the same as ::content's, because /content/ combinator should have almost the same behavior (except css text, ::content with descendant combinator). > > BUG=349334 > TEST=fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html,fast/dom/shadow/content-combinator-css-text.html,fast/dom/shadow/content-combinator-dynamic-attribute-change.html,fast/dom/shadow/content-combinator-in-inert-shadow.html,fast/dom/shadow/content-combinator-scoped.html,fast/dom/shadow/content-combinator-with-cat.html,fast/dom/shadow/content-combinator-with-hat.html,fast/dom/shadow/content-combinator-with-host-pseudo-class-2.html,fast/dom/shadow/content-combinator-with-host-pseudo-class.html,fast/dom/shadow/content-combinator.html,fast/dom/shadow/multiple-content-combinator.html,fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169085 BUG=349334 TBR=dglazkov@chromium.org,hayato@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169822

Patch Set 1 #

Patch Set 2 : Fixed patch conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -980 lines) Patch
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html View 1 2 chunks +24 lines, -27 lines 0 comments Download
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator.html View 1 1 chunk +0 lines, -225 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-css-text.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-css-text-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-dynamic-attribute-change.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-dynamic-attribute-change-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-in-inert-shadow.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-in-inert-shadow-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-scoped.html View 1 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-scoped-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class.html View 1 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class-2.html View 1 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class-2-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-shadow.html View 1 1 chunk +0 lines, -105 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-shadow-deep.html View 1 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-shadow-deep-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-combinator-with-shadow-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element.html View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-css-text.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-css-text-expected.txt View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-dynamic-attribute-change.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-dynamic-attribute-change-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-for-shadow-element.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-for-shadow-element-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-match-all.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-match-all-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-match-descendant.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-match-descendant-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-nested.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-nested-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-overridden.html View 1 1 chunk +10 lines, -12 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-expected.txt View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector-css-text.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector-css-text-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-reprojection.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-reprojection-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-scoped.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-scoped-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-specifiers-in-left-side.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-specifiers-in-left-side-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-support-selector.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-support-selector-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-used-in-selector-list.html View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-used-in-selector-list-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-any.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-any-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat.html View 1 11 chunks +12 lines, -17 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat-expected.txt View 1 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat.html View 1 9 chunks +9 lines, -14 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/dom/shadow/multiple-content-combinator.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/shadow/multiple-content-combinator-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content.html View 1 1 chunk +5 lines, -7 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 1 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/CSSParserValues.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSSelector.h View 1 5 chunks +8 lines, -2 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 6 chunks +10 lines, -4 lines 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelectorTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleSetTest.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/css/SelectorFilter.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tasak
Created Revert of Implement /content/ combinator.
6 years, 9 months ago (2014-03-20 02:42:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/205563004/1
6 years, 9 months ago (2014-03-20 02:42:17 UTC) #2
tasak
The CQ bit was unchecked by tasak@google.com
6 years, 9 months ago (2014-03-20 02:42:30 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 02:42:59 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/css/CSSSelector.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-20 02:43:00 UTC) #5
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-24 06:27:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/205563004/170001
6 years, 9 months ago (2014-03-24 06:27:32 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 06:48:03 UTC) #8
Message was sent while issue was closed.
Change committed as 169822

Powered by Google App Engine
This is Rietveld 408576698