Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 187353003: Implement /content/ combinator. (Closed)

Created:
6 years, 9 months ago by tasak
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Visibility:
Public.

Description

Implement /content/ combinator. spec: shadow styling http://dev.w3.org/csswg/shadow-styling/#content-combinator The added layout tests are basically the same as ::content's, because /content/ combinator should have almost the same behavior (except css text, ::content with descendant combinator). BUG=349334 TEST=fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html,fast/dom/shadow/content-combinator-css-text.html,fast/dom/shadow/content-combinator-dynamic-attribute-change.html,fast/dom/shadow/content-combinator-in-inert-shadow.html,fast/dom/shadow/content-combinator-scoped.html,fast/dom/shadow/content-combinator-with-cat.html,fast/dom/shadow/content-combinator-with-hat.html,fast/dom/shadow/content-combinator-with-host-pseudo-class-2.html,fast/dom/shadow/content-combinator-with-host-pseudo-class.html,fast/dom/shadow/content-combinator.html,fast/dom/shadow/multiple-content-combinator.html,fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169085

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Removed ::content #

Patch Set 4 : Fixed webkit_unit_tests #

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -1176 lines) Patch
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html View 1 2 2 chunks +27 lines, -24 lines 0 comments Download
M LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator.html View 1 2 1 chunk +225 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-css-text.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-css-text-expected.txt View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-dynamic-attribute-change.html View 1 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-dynamic-attribute-change-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-expected.txt View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-in-inert-shadow.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-in-inert-shadow-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-scoped.html View 1 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-scoped-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class-2.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class-2-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-with-host-pseudo-class-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-with-shadow-all.html View 1 2 9 chunks +14 lines, -9 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-with-shadow-all-expected.txt View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/content-combinator-with-shadow-deep.html View 1 2 11 chunks +17 lines, -12 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-combinator-with-shadow-deep-expected.txt View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element.html View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-css-text.html View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-css-text-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-dynamic-attribute-change.html View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-dynamic-attribute-change-expected.html View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-for-shadow-element.html View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-for-shadow-element-expected.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-match-all.html View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-match-all-expected.html View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-match-descendant.html View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-match-descendant-expected.html View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-nested.html View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-nested-expected.html View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-overridden.html View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2.html View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-2-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-overridden-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector.html View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector-css-text.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector-css-text-expected.txt View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-relative-selector-expected.html View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-reprojection.html View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-reprojection-expected.html View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-scoped.html View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-scoped-expected.html View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-specifiers-in-left-side.html View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-specifiers-in-left-side-expected.html View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-support-selector.html View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-support-selector-expected.html View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-used-in-selector-list.html View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-used-in-selector-list-expected.html View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-any.html View 1 2 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-any-expected.html View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat.html View 1 2 1 chunk +0 lines, -124 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-cat-expected.txt View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat.html View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-hat-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class.html View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2.html View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-2-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/fast/dom/shadow/content-pseudo-element-with-host-pseudo-class-expected.txt View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
A LayoutTests/fast/dom/shadow/multiple-content-combinator.html View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/multiple-content-combinator-expected.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator.html View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
A LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-content-combinator-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
D LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content.html View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/shadow/no-style-sharing-with-uncommon-attribute-and-pseudo-content-expected.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/css/CSSGrammar.y View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/CSSParserValues.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 1 2 5 chunks +3 lines, -9 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 1 2 7 chunks +4 lines, -11 lines 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelectorTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleSetTest.cpp View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/css/SelectorFilter.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 4 3 chunks +1 line, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tasak
6 years, 9 months ago (2014-03-05 06:59:20 UTC) #1
dglazkov
Should we be removing ::content at the same time? lgtm
6 years, 9 months ago (2014-03-05 17:05:32 UTC) #2
tasak
Thank you for reviewing. I created a new patch (including removing ::content). However, the patch ...
6 years, 9 months ago (2014-03-10 06:39:29 UTC) #3
tasak
On 2014/03/10 06:39:29, tasak wrote: > Thank you for reviewing. > > I created a ...
6 years, 9 months ago (2014-03-10 08:18:50 UTC) #4
tasak
Would you check the patch for removing ::content?
6 years, 9 months ago (2014-03-11 09:00:41 UTC) #5
dglazkov
lgtm
6 years, 9 months ago (2014-03-11 16:31:29 UTC) #6
tasak
The CQ bit was checked by tasak@google.com
6 years, 9 months ago (2014-03-13 01:09:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/187353003/110001
6 years, 9 months ago (2014-03-13 01:09:17 UTC) #8
commit-bot: I haz the power
Change committed as 169085
6 years, 9 months ago (2014-03-13 04:32:59 UTC) #9
tasak
6 years, 9 months ago (2014-03-20 02:42:10 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/205563004/ by tasak@google.com.

The reason for reverting is: Shadow DOM styling spec was changed.
/content/ was reverted in the spec.
.

Powered by Google App Engine
This is Rietveld 408576698