Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2055433002: Revert of service worker: Don't control a subframe of an insecure context (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-worker-reviews_chromium.org, chromium-reviews, Charlie Reis, creis+watch_chromium.org, darin-cc_chromium.org, estark, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, raymes, serviceworker-reviews, site-isolation-reviews_chromium.org, timwillis, Tom Sepez, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of service worker: Don't control a subframe of an insecure context (patchset #21 id:440001 of https://codereview.chromium.org/2009453002/ ) Reason for revert: ServiceWorkerProviderHost::SetControllerVersionAttribute CHECK is firing in release builds: https://crbug.com/618365 Original issue's description: > service worker: Don't control a subframe of an insecure context > > We must check isSecureContext when creating the network provider to > adhere to https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged. > > We already did this for getRegistration(), register(), unregister() but must > also do this when deciding whether to control an in-scope document. > > BUG=607543 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/59a2e54eeb0e61971a0c27c44c54dd0c30b5d06d > Cr-Commit-Position: refs/heads/master@{#398229} TBR=alexmos@chromium.org,clamy@chromium.org,horo@chromium.org,jww@chromium.org,kinuko@chromium.org,lazyboy@chromium.org,rdevlin.cronin@chromium.org,falken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=607543 Committed: https://crrev.com/c363d41a6001cb7b27789484702d23fa4572a918 Cr-Commit-Position: refs/heads/master@{#398660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -491 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/service_worker_apitest.cc View 3 chunks +3 lines, -20 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 8 chunks +12 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 5 chunks +7 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 5 chunks +0 lines, -25 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 6 chunks +1 line, -22 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 5 chunks +9 lines, -64 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 13 chunks +20 lines, -17 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.h View 2 chunks +4 lines, -11 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 5 chunks +11 lines, -25 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +2 lines, -13 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/insecure-parent-frame.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/insecure-inscope.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/insecure-parent.html View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +21 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Created Revert of service worker: Don't control a subframe of an insecure context
4 years, 6 months ago (2016-06-08 18:03:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055433002/1
4 years, 6 months ago (2016-06-08 18:04:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 20:29:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c363d41a6001cb7b27789484702d23fa4572a918 Cr-Commit-Position: refs/heads/master@{#398660}
4 years, 6 months ago (2016-06-08 20:32:46 UTC) #6
falken
4 years, 6 months ago (2016-06-09 19:36:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698