Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 2055433002: Revert of service worker: Don't control a subframe of an insecure context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_provider_host.cc
diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc
index 97caabdf1de84e1df7720c87f84724d494123e93..21e0ddf6239ab50140f37c2ac4180f613cd2beca 100644
--- a/content/browser/service_worker/service_worker_provider_host.cc
+++ b/content/browser/service_worker/service_worker_provider_host.cc
@@ -21,11 +21,8 @@
#include "content/common/service_worker/service_worker_messages.h"
#include "content/common/service_worker/service_worker_types.h"
#include "content/common/service_worker/service_worker_utils.h"
-#include "content/public/browser/content_browser_client.h"
#include "content/public/common/browser_side_navigation_policy.h"
#include "content/public/common/child_process_host.h"
-#include "content/public/common/content_client.h"
-#include "content/public/common/origin_util.h"
namespace content {
@@ -57,8 +54,7 @@
return std::unique_ptr<ServiceWorkerProviderHost>(
new ServiceWorkerProviderHost(
ChildProcessHost::kInvalidUniqueID, MSG_ROUTING_NONE, provider_id,
- SERVICE_WORKER_PROVIDER_FOR_WINDOW, FrameSecurityLevel::UNINITIALIZED,
- context, nullptr));
+ SERVICE_WORKER_PROVIDER_FOR_WINDOW, context, nullptr));
}
ServiceWorkerProviderHost::ServiceWorkerProviderHost(
@@ -66,7 +62,6 @@
int route_id,
int provider_id,
ServiceWorkerProviderType provider_type,
- FrameSecurityLevel parent_frame_security_level,
base::WeakPtr<ServiceWorkerContextCore> context,
ServiceWorkerDispatcherHost* dispatcher_host)
: client_uuid_(base::GenerateGUID()),
@@ -75,7 +70,6 @@
render_thread_id_(kDocumentMainThreadId),
provider_id_(provider_id),
provider_type_(provider_type),
- parent_frame_security_level_(parent_frame_security_level),
context_(context),
dispatcher_host_(dispatcher_host),
allow_association_(true) {
@@ -115,20 +109,6 @@
if (provider_type_ == SERVICE_WORKER_PROVIDER_FOR_WINDOW)
return route_id_;
return MSG_ROUTING_NONE;
-}
-
-bool ServiceWorkerProviderHost::IsContextSecureForServiceWorker() const {
- DCHECK(document_url_.is_valid());
- if (!OriginCanAccessServiceWorkers(document_url_))
- return false;
-
- if (is_parent_frame_secure())
- return true;
-
- std::set<std::string> schemes;
- GetContentClient()->browser()->GetSchemesBypassingSecureContextCheckWhitelist(
- &schemes);
- return schemes.find(document_url().scheme()) != schemes.end();
}
void ServiceWorkerProviderHost::OnVersionAttributesChanged(
@@ -185,7 +165,6 @@
void ServiceWorkerProviderHost::SetControllerVersionAttribute(
ServiceWorkerVersion* version,
bool notify_controllerchange) {
- CHECK(!version || IsContextSecureForServiceWorker());
if (version == controlling_version_.get())
return;

Powered by Google App Engine
This is Rietveld 408576698