Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: courgette/disassembler.cc

Issue 2055343002: Courgette: Add static method QuickDetect() to optimize program detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: courgette/disassembler.cc
diff --git a/courgette/disassembler.cc b/courgette/disassembler.cc
index baa3b1f8c780338f4750d63e8cbda29fb6e66d8b..de4caf1a8b825fc20814ca6507165fbfaa30d342 100644
--- a/courgette/disassembler.cc
+++ b/courgette/disassembler.cc
@@ -33,7 +33,7 @@ RVA Disassembler::RvaVisitor_Rel32::Get() const {
return *it_ + 4 + Read32LittleEndian(translator_.RVAToPointer(*it_));
}
-Disassembler::Disassembler(const void* start, size_t length)
+Disassembler::Disassembler(const uint8_t* start, size_t length)
: failure_reason_("uninitialized") {
start_ = reinterpret_cast<const uint8_t*>(start);
Will Harris 2016/06/13 19:15:21 no need for this cast now?
etiennep 2016/06/14 21:16:37 Done.
length_ = length;

Powered by Google App Engine
This is Rietveld 408576698