Courgette: Add static method QuickDetect() to optimize program detection.

courgette/disassembler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler.h"
 
 #include <memory>
 
 #include "base/logging.h"
 #include "courgette/assembly_program.h"
@@ skipping 15 matching lines @@
     const std::vector<RVA>& rva_locations,
     const AddressTranslator& translator)
     : VectorRvaVisitor<RVA>(rva_locations), translator_(translator) {
 }
 
 RVA Disassembler::RvaVisitor_Rel32::Get() const {
   // For Rel32 targets, only handle 32-bit offsets.
   return *it_ + 4 + Read32LittleEndian(translator_.RVAToPointer(*it_));
 }
 
-Disassembler::Disassembler(const void* start, size_t length)
+Disassembler::Disassembler(const uint8_t* start, size_t length)
     : failure_reason_("uninitialized") {
   start_ = reinterpret_cast<const uint8_t*>(start);

[Will Harris, 2016/06/13 19:15:21]

no need for this cast now?

[etiennep, 2016/06/14 21:16:37]

Done.

   length_ = length;
   end_ = start_ + length_;
 };
 
 Disassembler::~Disassembler() {};
 
 const uint8_t* Disassembler::FileOffsetToPointer(FileOffset file_offset) const {
   CHECK_LE(file_offset, static_cast<FileOffset>(end_ - start_));
   return start_ + file_offset;
 }
@@ skipping 22 matching lines @@
   program->PrecomputeLabels(abs32_visitor.get(), rel32_visitor.get());
 }
 
 void Disassembler::ReduceLength(size_t reduced_length) {
   CHECK_LE(reduced_length, length_);
   length_ = reduced_length;
   end_ = start_ + length_;
 }
 
 }  // namespace courgette