Add control over whether lines are special cased in SkDashPath. Disable when called from GrShape.

Add control over whether lines are special cased in SkDashPath. Disable when called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002

Committed: https://skia.googlesource.com/skia/+/398e3f4b9f67e0c7f635e68cae1ff7f42213bbfc

[bsalomon, 2016-06-10 14:51:43]

Description was changed from

==========
Add control over whether lines are special cased in SkDashPath. Disable when
called from GrShape.
==========

to

==========
Add control over whether lines are special cased in SkDashPath. Disable when
called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002
==========

[bsalomon, 2016-06-10 15:50:23]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, reed@google.com

[bsalomon, 2016-06-10 20:22:00]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 20:22:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055253002/40001

[commit-bot: I haz the power, 2016-06-10 20:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 20:40:32]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-06-13 14:24:05]

ping

[reed1, 2016-06-13 14:39:26]

minor, but the new param is a bool, and documented as a negative. Perhaps an
enum would be easier to use/read?

kAllow..., kDisallow...

[bsalomon, 2016-06-13 14:40:46]

On 2016/06/13 14:39:26, reed1 wrote:
> minor, but the new param is a bool, and documented as a negative. Perhaps an
> enum would be easier to use/read?
> 
> kAllow..., kDisallow...

will do

[bsalomon, 2016-06-13 14:48:16]

On 2016/06/13 14:40:46, bsalomon wrote:
> On 2016/06/13 14:39:26, reed1 wrote:
> > minor, but the new param is a bool, and documented as a negative. Perhaps an
> > enum would be easier to use/read?
> > 
> > kAllow..., kDisallow...
> 
> will do

Done

[bsalomon, 2016-06-13 15:05:57]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-13 15:06:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055253002/80001

[commit-bot: I haz the power, 2016-06-13 15:06:01]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-06-13 21:06 UTC

[reed1, 2016-06-13 17:20:37]

lgtm

[commit-bot: I haz the power, 2016-06-13 17:22:50]

Description was changed from

==========
Add control over whether lines are special cased in SkDashPath. Disable when
called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002
==========

to

==========
Add control over whether lines are special cased in SkDashPath. Disable when
called from GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2055253002

Committed:
https://skia.googlesource.com/skia/+/398e3f4b9f67e0c7f635e68cae1ff7f42213bbfc
==========

[commit-bot: I haz the power, 2016-06-13 17:22:51]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/398e3f4b9f67e0c7f635e68cae1ff7f42213bbfc