Fix GrShape to preserve inverseness of rrects for strokes but not dashes.

Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003

Committed: https://skia.googlesource.com/skia/+/fd32df716cfc787a3ac50efb293a9317a97078c5

[bsalomon, 2016-06-10 20:22:48]

Description was changed from

==========
Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
==========

to

==========
Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003
==========

[bsalomon, 2016-06-10 20:26:05]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com

[bsalomon, 2016-06-10 20:26:05]

I was wrong about stroking ignoring inverseness. It does not. But dashing does.

[bsalomon, 2016-06-13 15:04:27]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 15:04:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051263003/40001

[commit-bot: I haz the power, 2016-06-13 15:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 15:18:02]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-06-14 19:18:42]

ping

[bsalomon, 2016-06-14 19:21:46]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 19:21:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051263003/60001

[commit-bot: I haz the power, 2016-06-14 19:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:35:38]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-06-14 19:44:43]

https://codereview.chromium.org/2051263003/diff/60001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2051263003/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:1094: static const SkPath::Direction kExamplesStart =
SkPath::kCW_Direction;
Should the start be a index here and not a direction?

[bsalomon, 2016-06-14 19:48:27]

https://codereview.chromium.org/2051263003/diff/60001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2051263003/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:1094: static const SkPath::Direction kExamplesStart =
SkPath::kCW_Direction;
On 2016/06/14 19:44:43, egdaniel wrote:
> Should the start be a index here and not a direction?

derrrr. Fixed

[bsalomon, 2016-06-14 19:50:09]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 19:50:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051263003/80001

[egdaniel, 2016-06-14 19:58:07]

lgtm

[commit-bot: I haz the power, 2016-06-14 20:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 20:00:47]

Dry run: This issue passed the CQ dry run.

[bsalomon, 2016-06-14 21:08:28]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-06-14 21:08:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2051263003/80001

[commit-bot: I haz the power, 2016-06-14 21:37:24]

Description was changed from

==========
Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003
==========

to

==========
Fix GrShape to preserve inverseness of rrects for strokes but not dashes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2051263003

Committed:
https://skia.googlesource.com/skia/+/fd32df716cfc787a3ac50efb293a9317a97078c5
==========

[commit-bot: I haz the power, 2016-06-14 21:37:25]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/fd32df716cfc787a3ac50efb293a9317a97078c5