Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 205523003: Remove beforeload events. (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium, ojan
CC:
abarth-chromium, adamk+blink_chromium.org, arv+blink, blink-reviews, Inactive, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gavinp+loader_chromium.org, gavinp+prerender_chromium.org, gasubic, jamesr, Nate Chapin, rwlbuis, sof, nessy, vcarbune.chromium, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove beforeload events. This feature makes the insertedInto tree walk much more complicated and is the source of security bugs. We've had it disabled behind a flag for a while now and not seen complaints or bugs from users. BUG=333318 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169994

Patch Set 1 #

Patch Set 2 : Also remove all the tests #

Patch Set 3 : Make it pass the tests #

Patch Set 4 : Remove more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2415 lines) Patch
M LayoutTests/TestExpectations View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/draw-text-crash.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/canvas/draw-text-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/css/get-matched-css-rules-set-selector-text.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/css/get-matched-css-rules-set-selector-text-expected.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/link-beforeload-recursive.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/link-beforeload-recursive-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/prefetch-beforeload.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/prefetch-beforeload-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/dom/HTMLObjectElement/beforeload-set-text-crash-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/async-onbeforeload.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/async-onbeforeload-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/defer-onbeforeload.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/HTMLScriptElement/dont-load-unknown-type.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/move-in-beforeload.html View 1 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/move-in-beforeload-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/remove-in-beforeload.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/dom/HTMLScriptElement/remove-in-beforeload-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/Window/window-find-crash.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/dom/Window/window-find-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/beforeload/cached-image-before-load.html View 1 1 chunk +0 lines, -38 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/cached-image-before-load-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/clear-video-poster-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/flash-before-load.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/flash-before-load-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/beforeload/frame-before-load.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/frame-before-load-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/beforeload/image-before-load.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/image-before-load-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/beforeload/image-before-load-innerHTML.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/image-before-load-innerHTML-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/image-object-before-load.html View 1 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/image-object-before-load-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/image-object-before-load-innerHTML.html View 1 1 chunk +0 lines, -32 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/image-object-before-load-innerHTML-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/link-before-load.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/link-before-load-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/pi-before-load.xhtml View 1 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/pi-before-load-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html View 1 1 chunk +0 lines, -49 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener.html View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-flash-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-frame-in-beforeload-listener.html View 1 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-frame-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-image-in-beforeload-listener.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-image-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-link-in-beforeload-listener.html View 1 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-link-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-script-in-beforeload-listener.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-script-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-video-in-beforeload-listener.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-video-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-video-poster-in-beforeload-listener.html View 1 1 chunk +0 lines, -46 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/remove-video-poster-in-beforeload-listener-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/resources/fail.css View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/resources/fail.js View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/beforeload/resources/print.js View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/script-before-load.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/script-before-load-dynamic.html View 1 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/script-before-load-dynamic-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/script-before-load-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/script-before-load-xhtml.xhtml View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/script-before-load-xhtml-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/video-before-load.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/beforeload/video-before-load-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/events/beforeload-assertion.html View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/events/beforeload-assertion-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/events/beforeload-iframe-crash.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/events/beforeload-iframe-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/events/beforeload-input-time-crash.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/events/beforeload-input-time-crash-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/events/beforeload-input-time-crash2.html View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/events/beforeload-input-time-crash2-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/events/constructors/before-load-event-constructor.html View 1 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/fast/events/constructors/before-load-event-constructor-expected.txt View 1 1 chunk +0 lines, -32 lines 0 comments Download
M LayoutTests/fast/events/event-attribute.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/events/event-attribute-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/event-creation.html View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/events/event-creation-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/events/form-iframe-target-before-load-crash.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/events/form-iframe-target-before-load-crash-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/events/form-iframe-target-before-load-crash2.html View 1 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/fast/events/form-iframe-target-before-load-crash2-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/forms/form-iframe-target-before-load-detaches.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/fast/forms/form-iframe-target-before-load-detaches-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/frames/crash-remove-iframe-during-object-beforeload.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/frames/crash-remove-iframe-during-object-beforeload-2.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/frames/crash-remove-iframe-during-object-beforeload-2-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/frames/crash-remove-iframe-during-object-beforeload-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/frames/resources/remove-this-during-object-beforeload.html View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/images/image-beforeload-event-crash.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/images/image-beforeload-event-crash-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/js/constructor-length.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/constructor-length-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/parser/document-write-fighting-eof.html View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/parser/document-write-fighting-eof-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/parser/document-write-partial-entity-before-load.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/parser/document-write-partial-entity-before-load-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/parser/remove-misnested-iframe-in-beforeload.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/parser/remove-misnested-iframe-in-beforeload-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/parser/remove-misnested-iframe-parent-in-beforeload.html View 1 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/replaced/object-param-spaces.html View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/replaced/object-param-spaces-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/replaced/object-with-embed-url-param.html View 1 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/fast/replaced/object-with-embed-url-param-expected.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/tokenizer/write-before-load.html View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/tokenizer/write-before-load-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded.html View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/media/video-play-stall-before-meta-data.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/media/video-play-stall-before-meta-data-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/misc/link-rel-icon-beforeload.html View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/http/tests/misc/link-rel-icon-beforeload-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/http/tests/security/beforeload-iframe-client-redirect.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/beforeload-iframe-client-redirect-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/security/beforeload-iframe-server-redirect.html View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/http/tests/security/beforeload-iframe-server-redirect-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-control-char.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-null-char.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-src-inject.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-tag.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-tag-expected.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-tag-javascript-url.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/echo-object-src.pl View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/resources/utilities.js View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
D LayoutTests/media/media-blocked-by-beforeload.html View 1 1 chunk +0 lines, -139 lines 0 comments Download
D LayoutTests/media/media-blocked-by-beforeload-expected.txt View 1 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/media/video-beforeload-remove-source.html View 1 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/media/video-beforeload-remove-source-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading.html View 1 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/plugins/layout-in-beforeload-listener-affects-plugin-loading-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/scrollbars/hidden-iframe-scrollbar-crash2.html View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/scrollbars/hidden-iframe-scrollbar-crash2-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/scrollbars/resources/hidden-iframe-scrollbar-crash2.html View 1 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/dom/Node.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/events/BeforeLoadEvent.h View 1 2 1 chunk +0 lines, -94 lines 0 comments Download
D Source/core/events/BeforeLoadEvent.idl View 1 chunk +0 lines, -33 lines 0 comments Download
M Source/core/events/EventTypeNames.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 chunk +3 lines, -12 lines 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 3 chunks +2 lines, -23 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 6 chunks +8 lines, -21 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 2 chunks +3 lines, -6 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 2 2 chunks +0 lines, -21 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/ImageInputType.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/loader/ImageLoader.h View 3 chunks +1 line, -5 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 2 9 chunks +3 lines, -66 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebDOMEvent.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M public/web/WebDOMEvent.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-25 23:19:09 UTC) #1
esprehn
6 years, 9 months ago (2014-03-25 23:19:48 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-25 23:21:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/205523003/30001
6 years, 9 months ago (2014-03-25 23:21:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 23:57:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-25 23:57:47 UTC) #6
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-26 00:06:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/205523003/130001
6 years, 9 months ago (2014-03-26 00:06:47 UTC) #8
commit-bot: I haz the power
Change committed as 169994
6 years, 9 months ago (2014-03-26 01:12:21 UTC) #9
abarth-chromium
\o/
6 years, 9 months ago (2014-03-26 05:25:14 UTC) #10
philipj_slow
Yes please! Thank you abarth!
6 years, 9 months ago (2014-03-26 13:11:04 UTC) #11
philipj_slow
6 years, 9 months ago (2014-03-26 13:14:07 UTC) #12
Message was sent while issue was closed.
Oops, also thanks to esprehn who actually submitted the CL :)

Powered by Google App Engine
This is Rietveld 408576698