Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: Source/core/html/HTMLFrameElementBase.cpp

Issue 205523003: Remove beforeload events. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove more tests Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLImageElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann (hausmann@kde.org) 4 * (C) 2000 Simon Hausmann (hausmann@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 } else if (name == marginheightAttr) { 117 } else if (name == marginheightAttr) {
118 m_marginHeight = value.toInt(); 118 m_marginHeight = value.toInt();
119 // FIXME: If we are already attached, this has no effect. 119 // FIXME: If we are already attached, this has no effect.
120 } else if (name == scrollingAttr) { 120 } else if (name == scrollingAttr) {
121 // Auto and yes both simply mean "allow scrolling." No means "don't allo w scrolling." 121 // Auto and yes both simply mean "allow scrolling." No means "don't allo w scrolling."
122 if (equalIgnoringCase(value, "auto") || equalIgnoringCase(value, "yes")) 122 if (equalIgnoringCase(value, "auto") || equalIgnoringCase(value, "yes"))
123 m_scrolling = ScrollbarAuto; 123 m_scrolling = ScrollbarAuto;
124 else if (equalIgnoringCase(value, "no")) 124 else if (equalIgnoringCase(value, "no"))
125 m_scrolling = ScrollbarAlwaysOff; 125 m_scrolling = ScrollbarAlwaysOff;
126 // FIXME: If we are already attached, this has no effect. 126 // FIXME: If we are already attached, this has no effect.
127 } else if (name == onbeforeloadAttr) 127 } else if (name == onbeforeunloadAttr) {
128 setAttributeEventListener(EventTypeNames::beforeload, createAttributeEve ntListener(this, name, value));
129 else if (name == onbeforeunloadAttr) {
130 // FIXME: should <frame> elements have beforeunload handlers? 128 // FIXME: should <frame> elements have beforeunload handlers?
131 setAttributeEventListener(EventTypeNames::beforeunload, createAttributeE ventListener(this, name, value)); 129 setAttributeEventListener(EventTypeNames::beforeunload, createAttributeE ventListener(this, name, value));
132 } else 130 } else
133 HTMLFrameOwnerElement::parseAttribute(name, value); 131 HTMLFrameOwnerElement::parseAttribute(name, value);
134 } 132 }
135 133
136 void HTMLFrameElementBase::setNameAndOpenURL() 134 void HTMLFrameElementBase::setNameAndOpenURL()
137 { 135 {
138 m_frameName = getNameAttribute(); 136 m_frameName = getNameAttribute();
139 openURL(); 137 openURL();
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 221
224 int HTMLFrameElementBase::height() 222 int HTMLFrameElementBase::height()
225 { 223 {
226 document().updateLayoutIgnorePendingStylesheets(); 224 document().updateLayoutIgnorePendingStylesheets();
227 if (!renderBox()) 225 if (!renderBox())
228 return 0; 226 return 0;
229 return renderBox()->height(); 227 return renderBox()->height();
230 } 228 }
231 229
232 } // namespace WebCore 230 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLEmbedElement.cpp ('k') | Source/core/html/HTMLImageElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698