third_party/WebKit/public/platform/modules/payments/payment_request.mojom - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: why did I do that? Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java ('K') | « third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

diff --git a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

index ead29b970a2a5a540b600e3e4455e6d0fdc1edb7..f78531cdce62180b9ec66999e802ff6306fd9e94 100644

--- a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

+++ b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

@@ -107,6 +107,12 @@ struct PaymentMethodData {

string stringified_data;

};

+enum PaymentComplete {

+ SUCCESS,

+ FAIL,

+ UNKNOWN

+};

interface PaymentRequest {

SetClient(PaymentRequestClient client);

Show(array<PaymentMethodData> methodData,

@@ -114,5 +120,5 @@ interface PaymentRequest {

PaymentOptions options);

UpdateWith(PaymentDetails details);

Abort();

- Complete(bool success);

+ Complete(PaymentComplete result);

};