third_party/WebKit/Source/modules/payments/PaymentResponse.idl - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.idl

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: why did I do that? Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java ('K') | « third_party/WebKit/Source/modules/payments/PaymentResponse.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponse.idl

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.idl b/third_party/WebKit/Source/modules/payments/PaymentResponse.idl

index 2a4a4f5841d02b16b6b0e9cdf286f3470fa2afc6..5c44335f4e508502b1c9f510a7971915db02aad4 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.idl

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.idl

@@ -2,6 +2,14 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+// https://w3c.github.io/browser-payment-api/#idl-def-paymentcomplete

+enum PaymentComplete {

+ "success",

+ "fail",

+ ""

+};

// https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentresponse-interface

[

@@ -12,5 +20,5 @@

[CallWith=ScriptState, RaisesException] readonly attribute object details;

readonly attribute PaymentAddress? shippingAddress;

- [CallWith=ScriptState] Promise<void> complete(boolean success);

+ [CallWith=ScriptState] Promise<void> complete(optional PaymentComplete paymentResult = "");

};