third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: why did I do that? Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java ('K') | « third_party/WebKit/Source/modules/payments/PaymentCompleter.h ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index c150a99ce10fb17b32ebef7e3c1872e525a142d9..c501f3f03625da480ff17fd0f1244527d9d73f67 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -64,7 +64,7 @@ public:

ExecutionContext* getExecutionContext() const override;

// PaymentCompleter:

- ScriptPromise complete(ScriptState*, bool success) override;

+ ScriptPromise complete(ScriptState*, const PaymentComplete result) override;

// PaymentUpdater:

void onUpdatePaymentDetails(const ScriptValue& detailsScriptValue) override;