Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.idl

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.idl
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.idl b/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
index 10f9aabb31fd60bffa430950780fb51334d3f217..cc2e8feb6027bfe1156a6fcea6ec33eae0234b78 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.idl
@@ -2,6 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+// https://w3c.github.io/browser-payment-api/#idl-def-paymentcomplete
+
+enum PaymentComplete {
+ "success",
+ "fail",
+ ""
+};
+
// https://w3c.github.io/browser-payment-api/specs/paymentrequest.html#paymentresponse-interface
[
@@ -11,5 +19,5 @@
[CallWith=ScriptState, RaisesException] readonly attribute object details;
readonly attribute PaymentAddress? shippingAddress;
- [CallWith=ScriptState] Promise<void> complete(boolean success);
+ [CallWith=ScriptState] Promise<void> complete(optional PaymentComplete paymentResult = "");
};

Powered by Google App Engine
This is Rietveld 408576698