test/cctest/BUILD.gn - Issue 2054803003: [gn] Improve sharing common configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/BUILD.gn

Issue 2054803003: [gn] Improve sharing common configuration (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Better sharing Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/BUILD.gn

diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn

index 24f200285f4a6bc34a1008a752e967708be41599..49ba235223d8e1909f562054cb104b658dcd8ecd 100644

--- a/test/cctest/BUILD.gn

+++ b/test/cctest/BUILD.gn

@@ -6,7 +6,7 @@

import("../../gni/v8.gni")

-executable("cctest") {

+v8_executable("cctest") {

testonly = true

sources = [

@@ -283,13 +283,9 @@ executable("cctest") {

# },

}

- configs -= [ "//build/config/compiler:chromium_code" ]

- configs += [ "//build/config/compiler:no_chromium_code" ]

- configs += [

+ configs = [

"../..:external_config",

"../..:internal_config_base",

- "../..:features",

- "../..:toolchain",

]

# TODO(machenbach): Translate from gyp.

« no previous file with comments | « gni/v8.gni ('k') | test/unittests/BUILD.gn » ('j') | no next file with comments »