Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: test/unittests/BUILD.gn

Issue 2054803003: [gn] Improve sharing common configuration (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Better sharing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/BUILD.gn
diff --git a/test/unittests/BUILD.gn b/test/unittests/BUILD.gn
index 78720d095b8bc3dece0e306b006b0b5c0a695d64..949e6a3e7e470f223b6607e555df6157f1083547 100644
--- a/test/unittests/BUILD.gn
+++ b/test/unittests/BUILD.gn
@@ -6,7 +6,7 @@
import("../../gni/v8.gni")
-executable("unittests") {
+v8_executable("unittests") {
testonly = true
sources = [
@@ -136,13 +136,9 @@ executable("unittests") {
sources += [ "compiler/s390/instruction-selector-s390-unittest.cc" ]
}
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [
+ configs = [
"../..:external_config",
"../..:internal_config_base",
- "../..:features",
- "../..:toolchain",
]
# TODO(machenbach): Translate from gyp.
« no previous file with comments | « test/cctest/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698