Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2054803003: [gn] Improve sharing common configuration (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Improve sharing common configuration This moves common configs used by all v8 targets into common templates. This also fixes using v8_optimized_debug correctly in executables and components. BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/c1b24990277daa996db5ce84bf1a20d3dadd3751 Cr-Commit-Position: refs/heads/master@{#36956}

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Fixes #

Patch Set 4 : Better sharing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -68 lines) Patch
M BUILD.gn View 1 8 chunks +10 lines, -56 lines 0 comments Download
M gni/v8.gni View 1 2 3 2 chunks +56 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 chunks +2 lines, -6 lines 0 comments Download
M test/unittests/BUILD.gn View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Achenbach
PTAL. More context here: https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/4O4X5BkLS30
4 years, 6 months ago (2016-06-10 10:09:54 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-13 15:24:38 UTC) #4
vogelheim
lgtm This looks nicer indeed!
4 years, 6 months ago (2016-06-13 16:24:03 UTC) #5
Michael Achenbach
Landing this as it is for now. In the gn-dev threads are further suggestions which ...
4 years, 6 months ago (2016-06-14 09:28:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054803003/60001
4 years, 6 months ago (2016-06-14 10:04:07 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-14 10:07:32 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 10:09:48 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c1b24990277daa996db5ce84bf1a20d3dadd3751
Cr-Commit-Position: refs/heads/master@{#36956}

Powered by Google App Engine
This is Rietveld 408576698