chrome/browser/extensions/unpacked_installer.cc - Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 2054773002: Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the bug of delegated installs for pre-existing extensions Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_util.cc ('K') | « chrome/browser/extensions/installed_loader.cc ('k') | extensions/browser/extension_prefs.h » ('j') | extensions/browser/extension_prefs.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index f812a2f5f368e2391f6404ffb8128699c844337f..bc937bd4579510f671141238e374a90a58977c7c 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -258,9 +258,15 @@ int UnpackedInstaller::GetFlags() {

if (prefs->HasAllowFileAccessSetting(id))

allow_file_access = prefs->AllowFileAccess(id);

+ bool installed_by_custodian = false;

+ if (prefs->HasIsInstalledByCustodianSetting(id))

+ installed_by_custodian = prefs->IsInstalledByCustodian(id);

Marc Treib 2016/06/13 09:37:14 If this is unset, it should default to false anywa

mamir 2016/06/13 11:30:17 Done.

int result = Extension::FOLLOW_SYMLINKS_ANYWHERE;

if (allow_file_access)

result |= Extension::ALLOW_FILE_ACCESS;

+ if (installed_by_custodian)

+ result |= Extension::WAS_INSTALLED_BY_CUSTODIAN;

if (require_modern_manifest_version_)

result |= Extension::REQUIRE_MODERN_MANIFEST_VERSION;