Replace the WAS_INSTALLED_BY_CUSTODIAN creation flag with a pref

chrome/browser/extensions/unpacked_installer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/unpacked_installer.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/strings/string_util.h"
@@ skipping 240 matching lines @@
 }
 
 int UnpackedInstaller::GetFlags() {
   std::string id = crx_file::id_util::GenerateIdForPath(extension_path_);
   bool allow_file_access =
       Manifest::ShouldAlwaysAllowFileAccess(Manifest::UNPACKED);
   ExtensionPrefs* prefs = ExtensionPrefs::Get(service_weak_->profile());
   if (prefs->HasAllowFileAccessSetting(id))
     allow_file_access = prefs->AllowFileAccess(id);
 
+  bool installed_by_custodian = false;
+  if (prefs->HasIsInstalledByCustodianSetting(id))
+    installed_by_custodian = prefs->IsInstalledByCustodian(id);

[Marc Treib, 2016/06/13 09:37:14]

If this is unset, it should default to false anyway, right? Then we could get
rid of the Has... method.

[mamir, 2016/06/13 11:30:17]

Done.

+
   int result = Extension::FOLLOW_SYMLINKS_ANYWHERE;
   if (allow_file_access)
     result |= Extension::ALLOW_FILE_ACCESS;
+  if (installed_by_custodian)
+    result |= Extension::WAS_INSTALLED_BY_CUSTODIAN;
   if (require_modern_manifest_version_)
     result |= Extension::REQUIRE_MODERN_MANIFEST_VERSION;
 
   return result;
 }
 
 bool UnpackedInstaller::IsLoadingUnpackedAllowed() const {
   if (!service_weak_.get())
     return true;
   // If there is a "*" in the extension blacklist, then no extensions should be
@@ skipping 87 matching lines @@
   service_weak_->OnExtensionInstalled(
       extension(), syncer::StringOrdinal(), kInstallFlagInstallImmediately);
 
   if (!callback_.is_null()) {
     callback_.Run(extension(), extension_path_, std::string());
     callback_.Reset();
   }
 }
 
 }  // namespace extensions