Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2054673002: Mark shouldMarkObject(), arenaForNormalPage() accessors as const. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark shouldMarkObject(), arenaForNormalPage() accessors as const. Also remove some redundant checkHeader() asserts while doing a code tidying pass. R= BUG= Committed: https://crrev.com/b6f8d814a7f3a162a8cafd4644efec4016de74ea Cr-Commit-Position: refs/heads/master@{#398813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -34 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 8 chunks +6 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/InlinedGlobalMarkingVisitor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-09 06:09:03 UTC) #4
haraken
LGTM
4 years, 6 months ago (2016-06-09 06:13:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054673002/1
4 years, 6 months ago (2016-06-09 07:27:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 08:13:31 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 08:14:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6f8d814a7f3a162a8cafd4644efec4016de74ea
Cr-Commit-Position: refs/heads/master@{#398813}

Powered by Google App Engine
This is Rietveld 408576698