Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.cpp

Issue 2054673002: Mark shouldMarkObject(), arenaForNormalPage() accessors as const. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/HeapPage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/Heap.cpp
diff --git a/third_party/WebKit/Source/platform/heap/Heap.cpp b/third_party/WebKit/Source/platform/heap/Heap.cpp
index a6a75d4b01ffe538a3d2397e8a7e6f7e00de0b13..c2b0bb3e801c559c2a502c06c84bede3e602c5ac 100644
--- a/third_party/WebKit/Source/platform/heap/Heap.cpp
+++ b/third_party/WebKit/Source/platform/heap/Heap.cpp
@@ -440,17 +440,15 @@ void ThreadHeap::decommitCallbackStacks()
void ThreadHeap::preGC()
{
ASSERT(!ThreadState::current()->isInGC());
- for (ThreadState* state : m_threads) {
+ for (ThreadState* state : m_threads)
state->preGC();
- }
}
void ThreadHeap::postGC(BlinkGC::GCType gcType)
{
ASSERT(ThreadState::current()->isInGC());
- for (ThreadState* state : m_threads) {
+ for (ThreadState* state : m_threads)
state->postGC(gcType);
- }
}
const char* ThreadHeap::gcReasonString(BlinkGC::GCReason reason)
@@ -744,18 +742,16 @@ void ThreadHeap::visitPersistentRoots(Visitor* visitor)
TRACE_EVENT0("blink_gc", "ThreadHeap::visitPersistentRoots");
ProcessHeap::crossThreadPersistentRegion().tracePersistentNodes(visitor);
- for (ThreadState* state : m_threads) {
+ for (ThreadState* state : m_threads)
state->visitPersistents(visitor);
- }
}
void ThreadHeap::visitStackRoots(Visitor* visitor)
{
ASSERT(ThreadState::current()->isInGC());
TRACE_EVENT0("blink_gc", "ThreadHeap::visitStackRoots");
- for (ThreadState* state : m_threads) {
+ for (ThreadState* state : m_threads)
state->visitStack(visitor);
- }
}
void ThreadHeap::checkAndPark(ThreadState* threadState, SafePointAwareMutexLocker* locker)
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/HeapPage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698