Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 205463003: Merge r255817 and r257069: Do not initialize volume manager for signin profiles. (Closed)

Created:
6 years, 9 months ago by kinaba
Modified:
6 years, 9 months ago
Reviewers:
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Merge r255817 and r257069: Do not initialize volume manager for signin profiles. The first one fixies the buggy behavior. > Do not initialize the volume manager for sign in profiles. > > Since the volumes are not used, and moreover some of them are shared > between profiles, they volumes should not be mounted, and observers > shouldn't be added. > > TEST=Tested manually on a enterprise enrolled device. > BUG=349298 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255817 The second one is to address regressions due to the code depending on the above mentioned buggy behavior. > Accept the DISK_CHANGED event and force mounting. > > Before, the DISK_CHANGED event was ignored. However, it is required, to mount > disks which are not mounted, because mounting has been discarded because of > either: happened during sign-in, profile with kExternalStorageDisabled = true, > or before or during boot. > > TEST=Partly browser_tests. Tested manually on a enterprise enrolled chromebook. > BUG=349298 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257069 TBR=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chrome/browser/chromeos/file_manager/volume_manager.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinaba
6 years, 9 months ago (2014-03-20 01:56:05 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r258188 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698