Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/chromeos/file_manager/volume_manager_unittest.cc

Issue 205463003: Merge r255817 and r257069: Do not initialize volume manager for signin profiles. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1750/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/file_manager/volume_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/file_manager/volume_manager.h" 5 #include "chrome/browser/chromeos/file_manager/volume_manager.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 const LoggingObserver::Event& event = observer.events()[0]; 368 const LoggingObserver::Event& event = observer.events()[0];
369 EXPECT_EQ(LoggingObserver::Event::DISK_REMOVED, event.type); 369 EXPECT_EQ(LoggingObserver::Event::DISK_REMOVED, event.type);
370 EXPECT_EQ("device1", event.device_path); 370 EXPECT_EQ("device1", event.device_path);
371 371
372 ASSERT_EQ(0U, disk_mount_manager_->unmount_requests().size()); 372 ASSERT_EQ(0U, disk_mount_manager_->unmount_requests().size());
373 373
374 volume_manager_->RemoveObserver(&observer); 374 volume_manager_->RemoveObserver(&observer);
375 } 375 }
376 376
377 TEST_F(VolumeManagerTest, OnDiskEvent_Changed) { 377 TEST_F(VolumeManagerTest, OnDiskEvent_Changed) {
378 // Changed event is just ignored. 378 // Changed event should cause mounting (if possible).
379 LoggingObserver observer; 379 LoggingObserver observer;
380 volume_manager_->AddObserver(&observer); 380 volume_manager_->AddObserver(&observer);
381 381
382 const chromeos::disks::DiskMountManager::Disk kDisk( 382 const chromeos::disks::DiskMountManager::Disk kDisk(
383 "device1", "", "", "", "", "", "", "", "", "", "", "", 383 "device1", "", "", "", "", "", "", "", "", "", "", "",
384 chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, false, false, false); 384 chromeos::DEVICE_TYPE_UNKNOWN, 0, false, false, true, false, false);
385 volume_manager_->OnDiskEvent( 385 volume_manager_->OnDiskEvent(
386 chromeos::disks::DiskMountManager::DISK_CHANGED, &kDisk); 386 chromeos::disks::DiskMountManager::DISK_CHANGED, &kDisk);
387 387
388 EXPECT_EQ(0U, observer.events().size()); 388 EXPECT_EQ(1U, observer.events().size());
389 EXPECT_EQ(0U, disk_mount_manager_->mount_requests().size()); 389 EXPECT_EQ(1U, disk_mount_manager_->mount_requests().size());
390 EXPECT_EQ(0U, disk_mount_manager_->unmount_requests().size()); 390 EXPECT_EQ(0U, disk_mount_manager_->unmount_requests().size());
391 391
392 volume_manager_->RemoveObserver(&observer); 392 volume_manager_->RemoveObserver(&observer);
393 } 393 }
394 394
395 TEST_F(VolumeManagerTest, OnDeviceEvent_Added) { 395 TEST_F(VolumeManagerTest, OnDeviceEvent_Added) {
396 LoggingObserver observer; 396 LoggingObserver observer;
397 volume_manager_->AddObserver(&observer); 397 volume_manager_->AddObserver(&observer);
398 398
399 volume_manager_->OnDeviceEvent( 399 volume_manager_->OnDeviceEvent(
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 VolumeInfo volume_info; 665 VolumeInfo volume_info;
666 ASSERT_FALSE(volume_manager_->FindVolumeInfoById( 666 ASSERT_FALSE(volume_manager_->FindVolumeInfoById(
667 "nonexistent", &volume_info)); 667 "nonexistent", &volume_info));
668 ASSERT_TRUE(volume_manager_->FindVolumeInfoById( 668 ASSERT_TRUE(volume_manager_->FindVolumeInfoById(
669 "downloads:Downloads", &volume_info)); 669 "downloads:Downloads", &volume_info));
670 EXPECT_EQ("downloads:Downloads", volume_info.volume_id); 670 EXPECT_EQ("downloads:Downloads", volume_info.volume_id);
671 EXPECT_EQ(VOLUME_TYPE_DOWNLOADS_DIRECTORY, volume_info.type); 671 EXPECT_EQ(VOLUME_TYPE_DOWNLOADS_DIRECTORY, volume_info.type);
672 } 672 }
673 673
674 } // namespace file_manager 674 } // namespace file_manager
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/file_manager/volume_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698