Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2054623003:
Add control of manual mipmapping to GrContextOptions (Closed)
|
Created:
4 years, 6 months ago by Brian Osman Modified:
4 years, 6 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd control of manual mipmapping to GrContextOptions
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003
Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968
Committed: https://skia.googlesource.com/skia/+/9a3fbf7e559ca59a7b67a62be743496da1e31724
Patch Set 1 #
Total comments: 1
Patch Set 2 : Better comment #Patch Set 3 : Fix uninitialized variable #
Messages
Total messages: 27 (14 generated)
Description was changed from ========== Add control of manual mipmapping to GrContextOptions BUG=skia: ========== to ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 ==========
The CQ bit was checked by brianosman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054623003/1
brianosman@google.com changed reviewers: + bsalomon@google.com
Guess we want this?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2054623003/diff/1/include/gpu/GrContextOptions.h File include/gpu/GrContextOptions.h (right): https://codereview.chromium.org/2054623003/diff/1/include/gpu/GrContextOption... include/gpu/GrContextOptions.h:72: the driver's implementation (glGenerateMipmap) contains bugs. */ Comment that this requires mip map level/lod control?
The CQ bit was checked by brianosman@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com Link to the patchset: https://codereview.chromium.org/2054623003/#ps20001 (title: "Better comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054623003/20001
Message was sent while issue was closed.
Description was changed from ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 ========== to ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2050373002/ by mtklein@chromium.org. The reason for reverting is: https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT... ../../../src/gpu/gl/GrGLCaps.cpp:554:25: runtime error: load of value 187, which is not a valid value for type 'bool' SUMMARY: AddressSanitizer: undefined-behavior ../../../src/gpu/gl/GrGLCaps.cpp:554:25 in step returned non-zero exit code: 1 .
Message was sent while issue was closed.
Description was changed from ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968 ========== to ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968 ==========
The CQ bit was checked by brianosman@google.com to run a CQ dry run
The CQ bit was unchecked by brianosman@google.com
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054623003/40001
brianosman@google.com changed reviewers: + mtklein@google.com
... now with even less uninitialized memory access.
On 2016/06/09 19:41:13, bsalomon wrote: lgtm (now with even less empty strings)
The CQ bit was unchecked by brianosman@google.com
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054623003/40001
Message was sent while issue was closed.
Description was changed from ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968 ========== to ========== Add control of manual mipmapping to GrContextOptions BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968 Committed: https://skia.googlesource.com/skia/+/9a3fbf7e559ca59a7b67a62be743496da1e31724 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/9a3fbf7e559ca59a7b67a62be743496da1e31724 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
