components/content_settings/core/browser/host_content_settings_map.h - Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/host_content_settings_map.h

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/host_content_settings_map.h

diff --git a/components/content_settings/core/browser/host_content_settings_map.h b/components/content_settings/core/browser/host_content_settings_map.h

index b0d32142c3eb3aa86e9a74d71b568a474a1a51c3..ec33722e9996e4b9250274a0746a06ce9b1f436b 100644

--- a/components/content_settings/core/browser/host_content_settings_map.h

+++ b/components/content_settings/core/browser/host_content_settings_map.h

@@ -182,7 +182,7 @@ class HostContentSettingsMap : public content_settings::Observer,

const GURL& top_level_url,

ContentSettingsType content_type,

const std::string& resource_identifier,

- base::Value* value);

+ std::unique_ptr<base::Value> value);

// Sets a rule to apply the |value| for all sites matching |pattern|,

// |content_type| and |resource_identifier|. Setting the value to null removes

« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »