Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: components/content_settings/core/browser/host_content_settings_map.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/browser/host_content_settings_map.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/browser/host_content_settings_map.cc
diff --git a/components/content_settings/core/browser/host_content_settings_map.cc b/components/content_settings/core/browser/host_content_settings_map.cc
index fb595f9b2bf84f980e8411d0f13af2d7d82f5112..6b56ae6e7f863dec90f9a3cc482015fefa96ccb3 100644
--- a/components/content_settings/core/browser/host_content_settings_map.cc
+++ b/components/content_settings/core/browser/host_content_settings_map.cc
@@ -330,7 +330,7 @@ void HostContentSettingsMap::SetWebsiteSettingDefaultScope(
const GURL& secondary_url,
ContentSettingsType content_type,
const std::string& resource_identifier,
- base::Value* value) {
+ std::unique_ptr<base::Value> value) {
const WebsiteSettingsInfo* info =
content_settings::WebsiteSettingsRegistry::GetInstance()->Get(
content_type);
@@ -342,7 +342,7 @@ void HostContentSettingsMap::SetWebsiteSettingDefaultScope(
return;
SetWebsiteSettingCustomScope(primary_pattern, secondary_pattern, content_type,
- resource_identifier, base::WrapUnique(value));
+ resource_identifier, std::move(value));
}
void HostContentSettingsMap::SetWebsiteSettingCustomScope(
« no previous file with comments | « components/content_settings/core/browser/host_content_settings_map.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698