Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/ssl/chrome_ssl_host_state_delegate.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/chooser_context_base.cc ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
diff --git a/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc b/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
index e45257f432bfe8df0d09cfcca259c1840b05df8b..7d2fdfe27313ed2b82b05e905545eb20ded06ad9 100644
--- a/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
+++ b/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc
@@ -133,7 +133,7 @@ void MigrateOldSettings(HostContentSettingsMap* map) {
if (value) {
map->SetWebsiteSettingDefaultScope(
url, GURL(), CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS,
- std::string(), value.release());
+ std::string(), std::move(value));
}
}
}
@@ -310,7 +310,7 @@ void ChromeSSLHostStateDelegate::AllowCert(const std::string& host,
// SetWebsiteSettingDefaultScope.
map->SetWebsiteSettingDefaultScope(url, GURL(),
CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS,
- std::string(), value.release());
+ std::string(), std::move(value));
}
void ChromeSSLHostStateDelegate::Clear() {
@@ -378,7 +378,7 @@ void ChromeSSLHostStateDelegate::RevokeUserAllowExceptions(
map->SetWebsiteSettingDefaultScope(url, GURL(),
CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS,
- std::string(), NULL);
+ std::string(), nullptr);
}
// TODO(jww): This will revoke all of the decisions in the browser context.
« no previous file with comments | « chrome/browser/permissions/chooser_context_base.cc ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698