Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: chrome/browser/permissions/chooser_context_base.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/chooser_context_base.cc
diff --git a/chrome/browser/permissions/chooser_context_base.cc b/chrome/browser/permissions/chooser_context_base.cc
index 6ccdc07dc0275e243a02dd58b8ed3058315d7336..470f9ed6963b327b42b7fad8700cb0a2200db858 100644
--- a/chrome/browser/permissions/chooser_context_base.cc
+++ b/chrome/browser/permissions/chooser_context_base.cc
@@ -153,5 +153,5 @@ void ChooserContextBase::SetWebsiteSetting(const GURL& requesting_origin,
std::unique_ptr<base::Value> value) {
host_content_settings_map_->SetWebsiteSettingDefaultScope(
requesting_origin, embedding_origin, data_content_settings_type_,
- std::string(), value.release());
+ std::string(), std::move(value));
}
« no previous file with comments | « chrome/browser/engagement/site_engagement_score.cc ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698