Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_unittest.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_remover_unittest.cc
diff --git a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
index efd533c6617273bcf1f23f10253d1f0287f9b072..fb75dbf8c6bc1e84a2a3cb0752a039d07b138df3 100644
--- a/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
+++ b/chrome/browser/browsing_data/browsing_data_remover_unittest.cc
@@ -2421,16 +2421,16 @@ TEST_F(BrowsingDataRemoverTest, RemoveContentSettingsWithBlacklist) {
HostContentSettingsMapFactory::GetForProfile(GetProfile());
host_content_settings_map->SetWebsiteSettingDefaultScope(
kOrigin1, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
host_content_settings_map->SetWebsiteSettingDefaultScope(
kOrigin2, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
host_content_settings_map->SetWebsiteSettingDefaultScope(
kOrigin3, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
host_content_settings_map->SetWebsiteSettingDefaultScope(
kOrigin4, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
// Clear all except for origin1 and origin3.
RegistrableDomainFilterBuilder filter(
@@ -2516,14 +2516,14 @@ TEST_F(BrowsingDataRemoverTest, ClearWithPredicate) {
// Add settings.
host_content_settings_map->SetWebsiteSettingDefaultScope(
url1, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
// This setting should override the one above, as it's the same origin.
host_content_settings_map->SetWebsiteSettingDefaultScope(
url2, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
host_content_settings_map->SetWebsiteSettingDefaultScope(
url3, GURL(), CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(),
- new base::DictionaryValue());
+ base::WrapUnique(new base::DictionaryValue()));
// Verify we only have two.
host_content_settings_map->GetSettingsForOneType(
CONTENT_SETTINGS_TYPE_SITE_ENGAGEMENT, std::string(), &host_settings);

Powered by Google App Engine
This is Rietveld 408576698