Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1749)

Unified Diff: chrome/browser/banners/app_banner_settings_helper.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_settings_helper.cc
diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc
index 068a7c509b0ee3e750ee93e80b8581ec54117aed..5e54e7bd0715627aa42aa26f0f0a6c0e3ab442e4 100644
--- a/chrome/browser/banners/app_banner_settings_helper.cc
+++ b/chrome/browser/banners/app_banner_settings_helper.cc
@@ -286,9 +286,9 @@ void AppBannerSettingsHelper::RecordBannerEvent(
std::string event_key(kBannerEventKeys[event]);
app_dict->SetDouble(event_key, time.ToInternalValue());
- settings->SetWebsiteSettingDefaultScope(origin_url, GURL(),
- CONTENT_SETTINGS_TYPE_APP_BANNER,
- std::string(), origin_dict.release());
+ settings->SetWebsiteSettingDefaultScope(
+ origin_url, GURL(), CONTENT_SETTINGS_TYPE_APP_BANNER, std::string(),
+ std::move(origin_dict));
// App banner content settings are lossy, meaning they will not cause the
// prefs to become dirty. This is fine for most events, as if they are lost it
@@ -378,9 +378,9 @@ void AppBannerSettingsHelper::RecordBannerCouldShowEvent(
value->SetDouble(kBannerEngagementKey, engagement);
could_show_list->Append(std::move(value));
- settings->SetWebsiteSettingDefaultScope(origin_url, GURL(),
- CONTENT_SETTINGS_TYPE_APP_BANNER,
- std::string(), origin_dict.release());
+ settings->SetWebsiteSettingDefaultScope(
+ origin_url, GURL(), CONTENT_SETTINGS_TYPE_APP_BANNER, std::string(),
+ std::move(origin_dict));
}
bool AppBannerSettingsHelper::ShouldShowBanner(
« no previous file with comments | « no previous file | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698