chrome/browser/permissions/chooser_context_base.cc - Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/chooser_context_base.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/host_content_settings_map_unittest.cc ('K') | « chrome/browser/engagement/site_engagement_score.cc ('k') | chrome/browser/ssl/chrome_ssl_host_state_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/permissions/chooser_context_base.cc

diff --git a/chrome/browser/permissions/chooser_context_base.cc b/chrome/browser/permissions/chooser_context_base.cc

index 6ccdc07dc0275e243a02dd58b8ed3058315d7336..470f9ed6963b327b42b7fad8700cb0a2200db858 100644

--- a/chrome/browser/permissions/chooser_context_base.cc

+++ b/chrome/browser/permissions/chooser_context_base.cc

@@ -153,5 +153,5 @@ void ChooserContextBase::SetWebsiteSetting(const GURL& requesting_origin,

std::unique_ptr<base::Value> value) {

host_content_settings_map_->SetWebsiteSettingDefaultScope(

requesting_origin, embedding_origin, data_content_settings_type_,

- std::string(), value.release());

+ std::string(), std::move(value));

}