chrome/browser/content_settings/host_content_settings_map_unittest.cc - Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 2054623002: Refactor HostContentSettingsMap::SetWebsiteSettingDefaultScope to take a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('K') | « chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('k') | chrome/browser/engagement/site_engagement_score.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc

diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc

index 1532e97e05c277bbe8f931f0b235ccf1b60acab3..3e2f511a7b7962873880426371699ab5d5f5a820 100644

--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc

+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc

@@ -9,6 +9,7 @@

#include "base/command_line.h"

#include "base/json/json_reader.h"

#include "base/json/json_writer.h"

+#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

#include "chrome/browser/content_settings/content_settings_mock_observer.h"

#include "chrome/browser/content_settings/cookie_settings_factory.h"

@@ -851,7 +852,7 @@ TEST_F(HostContentSettingsMapTest, OffTheRecordDontInheritSetting) {

test_value.SetString("test", "value");

host_content_settings_map->SetWebsiteSettingDefaultScope(

host, host, CONTENT_SETTINGS_TYPE_USB_CHOOSER_DATA, std::string(),

- test_value.DeepCopy());

+ base::WrapUnique(test_value.DeepCopy()));

// The setting is not inherted by |otr_map|.

std::unique_ptr<base::Value> stored_value =