Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce
Patch Set: Fix building tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
index c2b10c03da91e9a412ea1ae7f859050a70106726..68099badaf4f53ad71f0ef4c0988021e0bf2dff6 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
@@ -46,6 +46,9 @@ public:
v8::Local<v8::Object> constructor() const;
v8::Local<v8::Object> prototype() const;
+ HTMLElement* createCustomElement(Document&, const QualifiedName&) override;
dominicc (has gone to gerrit) 2016/06/09 06:39:23 I think this name should be different. First, "cu
kojii 2016/06/09 16:54:21 Renaming done in PS4 and switched to ExceptionStat
+ HTMLElement* createCustomElementIgnoringErrors(Document&, const QualifiedName&) override;
+
private:
ScriptCustomElementDefinition(
ScriptState*,
@@ -60,6 +63,10 @@ private:
// Implementations of |CustomElementDefinition|
ScriptValue getConstructorForScript() final;
bool runConstructor(Element*) override;
+ Element* runConstructor();
+
+ void throwDOMException(int exceptionCode, const String&);
+ void throwTypeError(const String&);
RefPtr<ScriptState> m_scriptState;
ScopedPersistent<v8::Object> m_constructor;

Powered by Google App Engine
This is Rietveld 408576698