Implement "create an element" when sync for Custom Element V1

third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScriptCustomElementDefinition_h
 #define ScriptCustomElementDefinition_h
 
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/CoreExport.h"
@@ skipping 28 matching lines @@
         const v8::Local<v8::Object>& connectedCallback,
         const v8::Local<v8::Object>& disconnectedCallback,
         const v8::Local<v8::Object>& attributeChangedCallback,
         const HashSet<AtomicString>& observedAttributes);
 
     virtual ~ScriptCustomElementDefinition() = default;
 
     v8::Local<v8::Object> constructor() const;
     v8::Local<v8::Object> prototype() const;
 
+    HTMLElement* createCustomElement(Document&, const QualifiedName&) override;

[dominicc (has gone to gerrit), 2016/06/09 06:39:23]

I think this name should be different.

First, "custom" comes from the context--this is a CustomElementDefinition. We
have a lot of "custom element" and a lot of "create element" so it is not
*really* clear what this does.

WDYT about

createElementByRunningConstructor

Maybe these signatures should be:

HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&,
ExceptionState&) override;
HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&);

That way the ExceptionState& one can throw exceptions, and the exception
reporting one can just set up and pass and ExceptionState.

It looks like runConstructor wants to use ExceptionState too.
CustomElementDefinition::upgrade could use TrackExceptionState. Then
runConstructor does not need to return bool; callers can use
ExceptionState::hadException.

[kojii, 2016/06/09 16:54:21]

Renaming done in PS4 and switched to ExceptionState done in PS5.

+    HTMLElement* createCustomElementIgnoringErrors(Document&, const QualifiedName&) override;
+
 private:
     ScriptCustomElementDefinition(
         ScriptState*,
         const CustomElementDescriptor&,
         const v8::Local<v8::Object>& constructor,
         const v8::Local<v8::Object>& prototype,
         const v8::Local<v8::Object>& connectedCallback,
         const v8::Local<v8::Object>& disconnectedCallback,
         const v8::Local<v8::Object>& attributeChangedCallback,
         const HashSet<AtomicString>& observedAttributes);
 
     // Implementations of |CustomElementDefinition|
     ScriptValue getConstructorForScript() final;
     bool runConstructor(Element*) override;
+    Element* runConstructor();
+
+    void throwDOMException(int exceptionCode, const String&);
+    void throwTypeError(const String&);
 
     RefPtr<ScriptState> m_scriptState;
     ScopedPersistent<v8::Object> m_constructor;
     ScopedPersistent<v8::Object> m_prototype;
     ScopedPersistent<v8::Object> m_connectedCallback;
     ScopedPersistent<v8::Object> m_disconnectedCallback;
     ScopedPersistent<v8::Object> m_attributeChangedCallback;
     HashSet<AtomicString> m_observedAttributes;
 };
 
 } // namespace blink
 
 #endif // ScriptCustomElementDefinition_h