Implement "create an element" when sync for Custom Element V1

third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
index c2b10c03da91e9a412ea1ae7f859050a70106726..68099badaf4f53ad71f0ef4c0988021e0bf2dff6 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
@@ -46,6 +46,9 @@ public:
     v8::Local<v8::Object> constructor() const;
     v8::Local<v8::Object> prototype() const;
 
+    HTMLElement* createCustomElement(Document&, const QualifiedName&) override;

[dominicc (has gone to gerrit), 2016/06/09 06:39:23]

I think this name should be different.

First, "custom" comes from the context--this is a CustomElementDefinition. We
have a lot of "custom element" and a lot of "create element" so it is not
*really* clear what this does.

WDYT about

createElementByRunningConstructor

Maybe these signatures should be:

HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&,
ExceptionState&) override;
HTMLElement* createElementByRunningConstructor(Document&, const QualifiedName&);

That way the ExceptionState& one can throw exceptions, and the exception
reporting one can just set up and pass and ExceptionState.

It looks like runConstructor wants to use ExceptionState too.
CustomElementDefinition::upgrade could use TrackExceptionState. Then
runConstructor does not need to return bool; callers can use
ExceptionState::hadException.

[kojii, 2016/06/09 16:54:21]

Renaming done in PS4 and switched to ExceptionState done in PS5.

+    HTMLElement* createCustomElementIgnoringErrors(Document&, const QualifiedName&) override;
+
 private:
     ScriptCustomElementDefinition(
         ScriptState*,
@@ -60,6 +63,10 @@ private:
     // Implementations of |CustomElementDefinition|
     ScriptValue getConstructorForScript() final;
     bool runConstructor(Element*) override;
+    Element* runConstructor();
+
+    void throwDOMException(int exceptionCode, const String&);
+    void throwTypeError(const String&);
 
     RefPtr<ScriptState> m_scriptState;
     ScopedPersistent<v8::Object> m_constructor;