Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2054433002: Implement "create an element" when sync for Custom Element V1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@async-ce
Patch Set: dominicc review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 15dbe5a785f64644026c1faee0e4e9dc66d9f9d3..a6b116f2914c678dbf44f595578821d06df9510c 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -218,6 +218,9 @@ enum CreateElementFlags {
CreatedByParser = 1 << 0,
// Synchronous custom elements flag:
// https://dom.spec.whatwg.org/#concept-create-element
+ // TODO(kojii): Remove these flags, add an option to HTMLElementFactory
dominicc (has gone to gerrit) 2016/06/13 07:37:24 I think we should not let HTMLElementFactory ever
kojii 2016/06/13 13:44:31 I don't have opinions here, just tried to follow y
+ // not to queue upgrade, and let parser/DOM methods to upgrade synchronously
+ // when necessary.
SynchronousCustomElements = 0 << 1,
AsynchronousCustomElements = 1 << 1,

Powered by Google App Engine
This is Rietveld 408576698