Implement "create an element" when sync for Custom Element V1

third_party/WebKit/Source/core/dom/Document.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
@@ skipping 200 matching lines @@
 enum ShadowCascadeOrder {
     ShadowCascadeNone,
     ShadowCascadeV0,
     ShadowCascadeV1
 };
 
 enum CreateElementFlags {
     CreatedByParser = 1 << 0,
     // Synchronous custom elements flag:
     // https://dom.spec.whatwg.org/#concept-create-element
+    // TODO(kojii): Remove these flags, add an option to HTMLElementFactory

[dominicc (has gone to gerrit), 2016/06/13 07:37:24]

I think we should not let HTMLElementFactory ever queue upgrade because it won't
work with customized built-in elements. None of those call sites pass in "is." I
think it is better if the caller handles it.

If you want to do it this way, can you sketch the API for
HTMLElementFactory::createElement? How do all of the callers pass "is"?

[kojii, 2016/06/13 13:44:31]

I don't have opinions here, just tried to follow your previous advice. "To..."
was inaccurate probably, removed.

Thinking about the refactoring is on my queue, but haven't really spent time on
it yet.

+    // not to queue upgrade, and let parser/DOM methods to upgrade synchronously
+    // when necessary.
     SynchronousCustomElements = 0 << 1,
     AsynchronousCustomElements = 1 << 1,
 
     // Aliases by callers.
     // Clone a node: https://dom.spec.whatwg.org/#concept-node-clone
     CreatedByCloneNode = AsynchronousCustomElements,
     CreatedByImportNode = CreatedByCloneNode,
     // https://dom.spec.whatwg.org/#dom-document-createelement
     CreatedByCreateElement = SynchronousCustomElements,
     // https://html.spec.whatwg.org/#create-an-element-for-the-token
@@ skipping 1222 matching lines @@
 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 CORE_EXPORT void showLiveDocumentInstances();
 #endif
 
 #endif // Document_h