Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2054333002: Modify chooser controller to correctly handle removing item on Mac (Closed)

Created:
4 years, 6 months ago by juncai
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify chooser controller to correctly handle removing item on Mac This CL modified ChooserBubbleUiController and ChooserDialogCocoaController to correctly handle removing item. And it also added and updated test code to cover it. BUG=619230 Committed: https://crrev.com/d5ca45e05f2000f644a0b092813d294bcdcc5cc4 Cr-Commit-Position: refs/heads/master@{#399494}

Patch Set 1 : modified chooser controller to correctly handle removing item on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -108 lines) Patch
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm View 1 chunk +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 7 chunks +99 lines, -100 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
juncai
Please take a look.
4 years, 6 months ago (2016-06-10 23:59:19 UTC) #2
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-13 17:22:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054333002/1
4 years, 6 months ago (2016-06-13 17:27:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 18:48:50 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 18:49:11 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 18:51:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5ca45e05f2000f644a0b092813d294bcdcc5cc4
Cr-Commit-Position: refs/heads/master@{#399494}

Powered by Google App Engine
This is Rietveld 408576698