Modify chooser controller to correctly handle removing item on Mac

chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/strings/utf_string_conversions.h"
 #import "chrome/browser/ui/cocoa/chooser_content_view.h"
 #import "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h"
+#include "components/chooser_controller/mock_chooser_controller.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gtest_mac.h"
 
-namespace {
-
-class MockChooserController : public ChooserController {
- public:
-  explicit MockChooserController(content::RenderFrameHost* owner)
-      : ChooserController(owner) {}
-  ~MockChooserController() override {}
-
-  // ChooserController:
-  size_t NumOptions() const override { return option_names_.size(); }
-
-  // ChooserController:
-  const base::string16& GetOption(size_t index) const override {
-    return option_names_[index];
-  }
-
-  // ChooserController:
-  MOCK_METHOD1(Select, void(size_t index));
-
-  // ChooserController:
-  MOCK_METHOD0(Cancel, void());
-
-  // ChooserController:
-  MOCK_METHOD0(Close, void());
-
-  // ChooserController:
-  MOCK_CONST_METHOD0(OpenHelpCenterUrl, void());
-
-  void OptionAdded(const base::string16 option_name) {
-    option_names_.push_back(option_name);
-    if (observer())
-      observer()->OnOptionAdded(option_names_.size() - 1);
-  }
-
-  void OptionRemoved(const base::string16 option_name) {
-    for (auto it = option_names_.begin(); it != option_names_.end(); ++it) {
-      if (*it == option_name) {
-        size_t index = it - option_names_.begin();
-        option_names_.erase(it);
-        if (observer())
-          observer()->OnOptionRemoved(index);
-        return;
-      }
-    }
-  }
-
- private:
-  std::vector<base::string16> option_names_;
-
-  DISALLOW_COPY_AND_ASSIGN(MockChooserController);
-};
-
-}  // namespace
-
 class ChooserDialogCocoaControllerTest : public CocoaProfileTest {
  protected:
   ChooserDialogCocoaControllerTest() {}
   ~ChooserDialogCocoaControllerTest() override {}
 
   void SetUp() override {
     CocoaProfileTest::SetUp();
     ASSERT_TRUE(browser());
   }
 
@@ skipping 36 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ChooserDialogCocoaControllerTest);
 };
 
 TEST_F(ChooserDialogCocoaControllerTest, InitialState) {
   CreateChooserDialog();
 
   // Since "No devices found." needs to be displayed on the |table_view_|,
   // the number of rows is 1.
-  EXPECT_EQ(table_view_.numberOfRows, 1);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   // |table_view_| should be disabled since there is no option shown.
   ASSERT_FALSE(table_view_.enabled);
   // No option selected.
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
   // |connect_button_| should be disabled since no option selected.
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
   ASSERT_TRUE(help_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, AddOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
-  EXPECT_EQ(table_view_.numberOfRows, 1);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   // |table_view_| should be enabled since there is an option.
   ASSERT_TRUE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
   ASSERT_TRUE(help_button_.enabled);
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(2, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
-  EXPECT_EQ(table_view_.numberOfRows, 3);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(3, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, RemoveOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("b"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(2, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
 
   // Remove a non-existent option, the number of rows should not change.
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("non-existent"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(2, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("c"));
-  EXPECT_EQ(table_view_.numberOfRows, 1);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("a"));
   // There is no option shown now. But since "No devices found."
   // needs to be displayed on the |table_view_|, the number of rows is 1.
-  EXPECT_EQ(table_view_.numberOfRows, 1);
-  EXPECT_EQ(table_view_.numberOfColumns, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.numberOfColumns);
   // |table_view_| should be disabled since all options are removed.
   ASSERT_FALSE(table_view_.enabled);
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, AddAndRemoveOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
-  EXPECT_EQ(table_view_.numberOfRows, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
+  EXPECT_EQ(2, table_view_.numberOfRows);
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("b"));
-  EXPECT_EQ(table_view_.numberOfRows, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
+  EXPECT_EQ(2, table_view_.numberOfRows);
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("d"));
-  EXPECT_EQ(table_view_.numberOfRows, 3);
+  EXPECT_EQ(3, table_view_.numberOfRows);
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("d"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
+  EXPECT_EQ(2, table_view_.numberOfRows);
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("c"));
-  // There is no option shown now. But since "No devices found."
-  // needs to be displayed on the |table_view_|, the number of rows is 1.
-  EXPECT_EQ(table_view_.numberOfRows, 1);
+  EXPECT_EQ(1, table_view_.numberOfRows);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, SelectAndDeselectAnOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 0.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
-  EXPECT_EQ(table_view_.selectedRow, 0);
+  EXPECT_EQ(0, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 
-  // Disselect option 0.
+  // Deselect option 0.
   [table_view_ deselectRow:0];
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
   ASSERT_FALSE(connect_button_.enabled);
 
   // Select option 1.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
-  EXPECT_EQ(table_view_.selectedRow, 1);
+  EXPECT_EQ(1, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 
-  // Disselect option 1.
+  // Deselect option 1.
   [table_view_ deselectRow:1];
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
   ASSERT_FALSE(connect_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest,
        SelectAnOptionAndThenSelectAnotherOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 0.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
-  EXPECT_EQ(table_view_.selectedRow, 0);
+  EXPECT_EQ(0, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 
   // Select option 1.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
-  EXPECT_EQ(table_view_.selectedRow, 1);
+  EXPECT_EQ(1, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 
   // Select option 2.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:2]
            byExtendingSelection:NO];
-  EXPECT_EQ(table_view_.selectedRow, 2);
+  EXPECT_EQ(2, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 }
 
+TEST_F(ChooserDialogCocoaControllerTest, SelectAnOptionAndRemoveAnotherOption) {
+  CreateChooserDialog();
+
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
+
+  // Select option 1.
+  [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
+           byExtendingSelection:NO];
+  EXPECT_EQ(3, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.selectedRow);
+  ASSERT_TRUE(connect_button_.enabled);
+
+  // Remove option 0. The list becomes: b c. And the index of the previously
+  // selected item "b" becomes 0.
+  chooser_controller_->OptionRemoved(base::ASCIIToUTF16("a"));
+  EXPECT_EQ(2, table_view_.numberOfRows);
+  EXPECT_EQ(0, table_view_.selectedRow);
+  ASSERT_TRUE(connect_button_.enabled);
+
+  // Remove option 1. The list becomes: b.
+  chooser_controller_->OptionRemoved(base::ASCIIToUTF16("c"));
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(0, table_view_.selectedRow);
+  ASSERT_TRUE(connect_button_.enabled);
+}
+
 TEST_F(ChooserDialogCocoaControllerTest,
        SelectAnOptionAndRemoveTheSelectedOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 1.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
-  EXPECT_EQ(table_view_.numberOfRows, 3);
-  EXPECT_EQ(table_view_.selectedRow, 1);
+  EXPECT_EQ(3, table_view_.numberOfRows);
+  EXPECT_EQ(1, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 
   // Remove option 1
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("b"));
-  EXPECT_EQ(table_view_.numberOfRows, 2);
+  EXPECT_EQ(2, table_view_.numberOfRows);
   // No option selected.
-  EXPECT_EQ(table_view_.selectedRow, -1);
+  EXPECT_EQ(-1, table_view_.selectedRow);
   // Since no option selected, the "Connect" button should be disabled.
   ASSERT_FALSE(connect_button_.enabled);
 }
+
+TEST_F(ChooserDialogCocoaControllerTest,
+       AddAnOptionAndSelectItAndRemoveTheSelectedOption) {
+  CreateChooserDialog();
+
+  chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
+
+  // Select option 0.
+  [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
+           byExtendingSelection:NO];
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  EXPECT_EQ(0, table_view_.selectedRow);
+  ASSERT_TRUE(connect_button_.enabled);
+
+  // Remove option 0.
+  chooser_controller_->OptionRemoved(base::ASCIIToUTF16("a"));
+  // There is no option shown now. But since "No devices found."
+  // needs to be displayed on the |table_view_|, the number of rows is 1.
+  EXPECT_EQ(1, table_view_.numberOfRows);
+  // No option selected.
+  EXPECT_EQ(-1, table_view_.selectedRow);
+  // |table_view_| should be disabled since there is no option shown.
+  ASSERT_FALSE(table_view_.enabled);
+  // Since no option selected, the "Connect" button should be disabled.
+  ASSERT_FALSE(connect_button_.enabled);
+}
 
 TEST_F(ChooserDialogCocoaControllerTest, NoOptionSelectedAndPressCancelButton) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   EXPECT_CALL(*chooser_controller_, Select(testing::_)).Times(0);
   EXPECT_CALL(*chooser_controller_, Cancel()).Times(1);
@@ skipping 45 matching lines @@
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 0 and press "Get help" button.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_CALL(*chooser_controller_, Select(testing::_)).Times(0);
   EXPECT_CALL(*chooser_controller_, Cancel()).Times(0);
   EXPECT_CALL(*chooser_controller_, OpenHelpCenterUrl()).Times(1);
   [help_button_ performClick:chooser_dialog_controller_];
 }