Add documention on SkBlitter for runs, and small cleanups.

Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002

Committed: https://skia.googlesource.com/skia/+/3be72b0413ebc7cb1133e704169e3d543830d8e7

[herb_g, 2016-06-10 20:32:48]

Description was changed from

==========
Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
==========

to

==========
Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002
==========

[herb_g, 2016-06-10 20:33:28]

Description was changed from

==========
Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002
==========

to

==========
Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002
==========

[herb_g, 2016-06-10 20:33:29]

herb@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-06-10 20:40:46]

SkAssertResult(...) from cary

https://codereview.chromium.org/2054213002/diff/1/src/core/SkBlitter_ARGB32.cpp
File src/core/SkBlitter_ARGB32.cpp (right):

https://codereview.chromium.org/2054213002/diff/1/src/core/SkBlitter_ARGB32.c...
src/core/SkBlitter_ARGB32.cpp:182: SkASSERT(SkBlitMask::BlitColor(fDevice, mask,
clip, fColor));
SkASSERT_ALWAYS?

[herb_g, 2016-06-10 20:49:06]

Fix bad use of SkASSERT

[herb_g, 2016-06-10 20:56:48]

https://codereview.chromium.org/2054213002/diff/1/src/core/SkBlitter_ARGB32.cpp
File src/core/SkBlitter_ARGB32.cpp (right):

https://codereview.chromium.org/2054213002/diff/1/src/core/SkBlitter_ARGB32.c...
src/core/SkBlitter_ARGB32.cpp:182: SkASSERT(SkBlitMask::BlitColor(fDevice, mask,
clip, fColor));
On 2016/06/10 20:40:45, reed1 wrote:
> SkASSERT_ALWAYS?

Done.

[herb_g, 2016-06-10 20:57:05]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 20:57:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054213002/20001

[commit-bot: I haz the power, 2016-06-10 21:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 21:19:08]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-06-13 11:03:14]

https://codereview.chromium.org/2054213002/diff/20001/src/core/SkBlitter_ARGB...
File src/core/SkBlitter_ARGB32.cpp (right):

https://codereview.chromium.org/2054213002/diff/20001/src/core/SkBlitter_ARGB...
src/core/SkBlitter_ARGB32.cpp:199: SkAssertResult(SkBlitMask::BlitColor(fDevice,
mask, clip, fColor));
My read is the BlitColor was written as a chance for optimizations, so the
caller invoked it first, and only then handled the other cases (as needed). This
change subtly changes that, not giving it a chance at BW or ARGB32. If this is
the new correct, perhaps we should rename or somehow indicate that in BlitColor
(even moving the assert inside it instead of w/ the caller). What do you think?

[herb_g, 2016-06-22 17:51:47]

Fix broken dispatch code.

[herb_g, 2016-06-22 17:52:14]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 17:52:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054213002/40001

[commit-bot: I haz the power, 2016-06-22 17:53:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 17:53:28]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-06-22 17:54:53]

PTAL

https://codereview.chromium.org/2054213002/diff/20001/src/core/SkBlitter_ARGB...
File src/core/SkBlitter_ARGB32.cpp (right):

https://codereview.chromium.org/2054213002/diff/20001/src/core/SkBlitter_ARGB...
src/core/SkBlitter_ARGB32.cpp:199: SkAssertResult(SkBlitMask::BlitColor(fDevice,
mask, clip, fColor));
On 2016/06/13 11:03:14, reed1 wrote:
> My read is the BlitColor was written as a chance for optimizations, so the
> caller invoked it first, and only then handled the other cases (as needed).
This
> change subtly changes that, not giving it a chance at BW or ARGB32. If this is
> the new correct, perhaps we should rename or somehow indicate that in
BlitColor
> (even moving the assert inside it instead of w/ the caller). What do you
think?

Fixed.
I had assumed that the BlitColor call and the if statement were disjoint,
because the if statement did not handle all cases.

[herb_g, 2016-06-23 13:50:55]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 13:50:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2054213002/40001

[commit-bot: I haz the power, 2016-06-23 14:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 14:06:48]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-06-23 18:39:39]

lgtm

[herb_g, 2016-06-24 19:44:44]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-06-24 19:44:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 20:02:34]

Description was changed from

==========
Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002
==========

to

==========
Add documention on SkBlitter for runs, and small cleanups.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054213002

Committed:
https://skia.googlesource.com/skia/+/3be72b0413ebc7cb1133e704169e3d543830d8e7
==========

[commit-bot: I haz the power, 2016-06-24 20:02:35]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3be72b0413ebc7cb1133e704169e3d543830d8e7