service worker: Fix the type of an update promise reject value

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp
index 4a37638130145923ce250a1cc8d45c88971d5fdf..36c64ca56907e258b76fb841db4bac949d656f77 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp
@@ -55,6 +55,7 @@ DOMException* ServiceWorkerError::take(ScriptPromiseResolver*, const WebServiceW
     case WebServiceWorkerError::ErrorTypeDisabled:
         return createException(NotSupportedError, "Service Worker support is disabled.", webError.message);
     case WebServiceWorkerError::ErrorTypeInstall:
+    case WebServiceWorkerError::ErrorTypeScriptEvaluateFailed:

[falken, 2016/06/14 02:27:53]

The SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED error code can be used outside
of installation. For example, starting a worker can fail with this error code.
If we're adding this WebServiceWorkerError code, we shouldn't assume it's only
used in installation.

[e_hakkinen, 2016/06/16 20:55:14]

This is mainly for not to break other callers of this functions.
Once all callers map script evaluate failures correctly to TypeError, the
ErrorTypeScriptEvaluateFailed case can be merged with the ErrorTypeType branch
which does ASSERT_NOT_REACHED.

[falken, 2016/06/17 02:12:14]

It'd be unfortunate for each callsite to have to special case
ScriptEvaluteFailed. Fortunately, I think the only callsite that can get a
ScriptEvaluateFailed is the register promise case. So if that's changed over, we
should be able to do ASSERT_NOT_REACHED here. 

Otherwise, we should make ServiceWorkerError::take be able to create a
TypeError.

         // FIXME: Introduce new InstallError type to ExceptionCodes?
         return createException(AbortError, "The Service Worker installation failed.", webError.message);
     case WebServiceWorkerError::ErrorTypeNavigation: