service worker: Fix the type of an update promise reject value

third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerError.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 37 matching lines @@
     switch (webError.errorType) {
     case WebServiceWorkerError::ErrorTypeAbort:
         return createException(AbortError, "The Service Worker operation was aborted.", webError.message);
     case WebServiceWorkerError::ErrorTypeActivate:
         // Not currently returned as a promise rejection.
         // FIXME: Introduce new ActivateError type to ExceptionCodes?
         return createException(AbortError, "The Service Worker activation failed.", webError.message);
     case WebServiceWorkerError::ErrorTypeDisabled:
         return createException(NotSupportedError, "Service Worker support is disabled.", webError.message);
     case WebServiceWorkerError::ErrorTypeInstall:
+    case WebServiceWorkerError::ErrorTypeScriptEvaluateFailed:

[falken, 2016/06/14 02:27:53]

The SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED error code can be used outside
of installation. For example, starting a worker can fail with this error code.
If we're adding this WebServiceWorkerError code, we shouldn't assume it's only
used in installation.

[e_hakkinen, 2016/06/16 20:55:14]

This is mainly for not to break other callers of this functions.
Once all callers map script evaluate failures correctly to TypeError, the
ErrorTypeScriptEvaluateFailed case can be merged with the ErrorTypeType branch
which does ASSERT_NOT_REACHED.

[falken, 2016/06/17 02:12:14]

It'd be unfortunate for each callsite to have to special case
ScriptEvaluteFailed. Fortunately, I think the only callsite that can get a
ScriptEvaluateFailed is the register promise case. So if that's changed over, we
should be able to do ASSERT_NOT_REACHED here. 

Otherwise, we should make ServiceWorkerError::take be able to create a
TypeError.

         // FIXME: Introduce new InstallError type to ExceptionCodes?
         return createException(AbortError, "The Service Worker installation failed.", webError.message);
     case WebServiceWorkerError::ErrorTypeNavigation:
         // ErrorTypeNavigation should have bailed out before calling this.
         ASSERT_NOT_REACHED();
         return DOMException::create(UnknownError);
     case WebServiceWorkerError::ErrorTypeNetwork:
         return createException(NetworkError, "The Service Worker failed by network.", webError.message);
     case WebServiceWorkerError::ErrorTypeNotFound:
         return createException(NotFoundError, "The specified Service Worker resource was not found.", webError.message);
     case WebServiceWorkerError::ErrorTypeSecurity:
         return createException(SecurityError, "The Service Worker security policy prevented an action.", webError.message);
     case WebServiceWorkerError::ErrorTypeState:
         return createException(InvalidStateError, "The Service Worker state was not valid.", webError.message);
     case WebServiceWorkerError::ErrorTypeTimeout:
         return createException(AbortError, "The Service Worker operation timed out.", webError.message);
     case WebServiceWorkerError::ErrorTypeUnknown:
         return createException(UnknownError, "An unknown error occurred within Service Worker.", webError.message);
     case WebServiceWorkerError::ErrorTypeType:
         // ErrorTypeType should have been handled before reaching this point.
         ASSERT_NOT_REACHED();
         return DOMException::create(UnknownError);
     }
     ASSERT_NOT_REACHED();
     return DOMException::create(UnknownError);
 }
 
 } // namespace blink