content/browser/renderer_host/text_input_manager.h - Issue 2054163003: Fix SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame on CFI Bots.

Unified Diff: content/browser/renderer_host/text_input_manager.h

Issue 2054163003: Fix SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame on CFI Bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not assume we only have 2 views registered in the begining. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('K') | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/public/test/text_input_test_utils.h » ('j') | content/public/test/text_input_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/text_input_manager.h

diff --git a/content/browser/renderer_host/text_input_manager.h b/content/browser/renderer_host/text_input_manager.h

index 7dcbdfc2e82fcfc0078e75b3a8f52228d2193411..977c47a6d4ea0eb3c86ae726161060fc9778a6db 100644

--- a/content/browser/renderer_host/text_input_manager.h

+++ b/content/browser/renderer_host/text_input_manager.h

@@ -6,6 +6,7 @@

#define CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_MANAGER_H__

#include <unordered_map>

+#include <unordered_set>

#include "base/observer_list.h"

#include "content/common/content_export.h"

@@ -81,6 +82,8 @@ class CONTENT_EXPORT TextInputManager {

friend bool GetTextInputTypeForView(WebContents* web_contents,

RenderWidgetHostView* view,

ui::TextInputType* type);

+ friend std::unordered_set<RenderWidgetHostView*>

+ GetAllViewsRegisteredWithTextInputManager(WebContents* web_contents);

Charlie Reis 2016/06/13 18:46:13 I'm not thrilled with having lots of raw test meth

EhsanK 2016/06/25 00:10:35 Apparently I had miss(e|understoo)d that comment.

Charlie Reis 2016/06/28 18:12:41 I like how patch set 5 has two limited testing met

void NotifyObserversAboutInputStateUpdate(RenderWidgetHostViewBase* view,

bool did_update_state);