Fix SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame on CFI Bots.

content/browser/renderer_host/text_input_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_MANAGER_H__
 #define CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_MANAGER_H__
 
 #include <unordered_map>
+#include <unordered_set>
 
 #include "base/observer_list.h"
 #include "content/common/content_export.h"
 #include "content/common/text_input_state.h"
 
 namespace content {
 
 class RenderWidgetHostView;
 class RenderWidgetHostViewBase;
 class WebContents;
@@ skipping 55 matching lines @@
   // Only the tab's RWHV should observer TextInputManager. In tests, however,
   // in addition to the tab's RWHV, one or more test observers might observe
   // TextInputManager.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
  private:
   friend bool GetTextInputTypeForView(WebContents* web_contents,
                                       RenderWidgetHostView* view,
                                       ui::TextInputType* type);
+  friend std::unordered_set<RenderWidgetHostView*>
+  GetAllViewsRegisteredWithTextInputManager(WebContents* web_contents);

[Charlie Reis, 2016/06/13 18:46:13]

I'm not thrilled with having lots of raw test methods declared as friends.  I'd
requested avoiding the first one as well, but I think that request fell between
the cracks:
https://codereview.chromium.org/1948343002/diff/280001/content/browser/render...

I'd much rather have public *ForTesting methods on this class, which makes it
clearer what's exposed and why.  Can we update both of these?

[EhsanK, 2016/06/25 00:10:35]

Apparently I had miss(e|understoo)d that comment. Sorry for that.

I did add only one method for testing which returns the whole map itself. I use
this to obtain both type and the count in public API.

Do you think this is OK, or should I have two limited testing methods her, one
for count and another for type?

[Charlie Reis, 2016/06/28 18:12:41]

I like how patch set 5 has two limited testing methods (one for count and
another for type).

 
   void NotifyObserversAboutInputStateUpdate(RenderWidgetHostViewBase* view,
                                             bool did_update_state);
 
   // The view with active text input state.
   RenderWidgetHostViewBase* active_view_;
 
   std::unordered_map<RenderWidgetHostViewBase*, TextInputState>
       text_input_state_map_;
 
   base::ObserverList<Observer> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(TextInputManager);
 };
 }
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_TEXT_INPUT_MANAGER_H__