Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 205413004: Add two classes [as yet unused] needed for upcoming IDB Blob support. (Closed)

Created:
6 years, 9 months ago by ericu
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Add two classes [as yet unused] needed for upcoming IDB Blob support. BUG=108012 R=cmumford,jsbell,abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170686

Patch Set 1 #

Total comments: 20

Patch Set 2 : Rolled in code review feedback. #

Total comments: 1

Patch Set 3 : Remove BlobInfo; we can just use WebBlobInfo. #

Patch Set 4 : tiny style fix #

Patch Set 5 : Clean up branch #

Patch Set 6 : Clean up branch again. #

Patch Set 7 : Trying again #

Patch Set 8 : More fixing #

Patch Set 9 : Fixed the branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -0 lines) Patch
A public/platform/WebBlobInfo.h View 1 2 3 4 5 6 7 8 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
ericu
Here's the first piece of the blink side.
6 years, 9 months ago (2014-03-20 15:04:28 UTC) #1
jsbell
Just a quick glance, leaving the details to cmumford https://codereview.chromium.org/205413004/diff/1/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (right): https://codereview.chromium.org/205413004/diff/1/Source/platform/blink_platform.gypi#newcode243 Source/platform/blink_platform.gypi:243: ...
6 years, 9 months ago (2014-03-20 16:00:45 UTC) #2
cmumford
https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h File Source/platform/blob/BlobInfo.h (right): https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h#newcode42 Source/platform/blob/BlobInfo.h:42: , m_size(-1) Should initialize m_lastModified. https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h#newcode85 Source/platform/blob/BlobInfo.h:85: String m_type; ...
6 years, 9 months ago (2014-03-20 18:22:32 UTC) #3
jsbell
https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h File Source/platform/blob/BlobInfo.h (right): https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h#newcode85 Source/platform/blob/BlobInfo.h:85: String m_type; // mime type On 2014/03/20 18:22:32, cmumford ...
6 years, 9 months ago (2014-03-20 18:30:28 UTC) #4
cmumford
https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h File Source/platform/blob/BlobInfo.h (right): https://codereview.chromium.org/205413004/diff/1/Source/platform/blob/BlobInfo.h#newcode85 Source/platform/blob/BlobInfo.h:85: String m_type; // mime type On 2014/03/20 18:30:29, jsbell ...
6 years, 9 months ago (2014-03-24 23:17:46 UTC) #5
ericu
https://codereview.chromium.org/205413004/diff/1/Source/platform/blink_platform.gypi File Source/platform/blink_platform.gypi (right): https://codereview.chromium.org/205413004/diff/1/Source/platform/blink_platform.gypi#newcode243 Source/platform/blink_platform.gypi:243: 'blob/BlobInfo.h', On 2014/03/20 16:00:46, jsbell wrote: > So... with ...
6 years, 9 months ago (2014-03-25 00:00:26 UTC) #6
jsbell
lgtm
6 years, 9 months ago (2014-03-25 00:12:54 UTC) #7
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 8 months ago (2014-04-01 21:34:37 UTC) #8
ericu
The CQ bit was unchecked by ericu@chromium.org
6 years, 8 months ago (2014-04-01 21:36:27 UTC) #9
ericu
+abarth for owner approval.
6 years, 8 months ago (2014-04-01 21:39:42 UTC) #10
abarth-chromium
LGTM https://codereview.chromium.org/205413004/diff/20001/Source/platform/blob/BlobInfo.h File Source/platform/blob/BlobInfo.h (right): https://codereview.chromium.org/205413004/diff/20001/Source/platform/blob/BlobInfo.h#newcode12 Source/platform/blob/BlobInfo.h:12: class BlobInfo { You might not need this ...
6 years, 8 months ago (2014-04-01 21:48:04 UTC) #11
cmumford
On 2014/04/01 21:36:27, ericu wrote: > The CQ bit was unchecked by mailto:ericu@chromium.org LGTM
6 years, 8 months ago (2014-04-01 21:50:58 UTC) #12
ericu
Great--thanks Adam. That simplifies things a bunch.
6 years, 8 months ago (2014-04-02 18:28:26 UTC) #13
ericu
The CQ bit was checked by ericu@chromium.org
6 years, 8 months ago (2014-04-02 18:28:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/205413004/160001
6 years, 8 months ago (2014-04-02 18:28:40 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:36:18 UTC) #16
Message was sent while issue was closed.
Change committed as 170686

Powered by Google App Engine
This is Rietveld 408576698