Add two classes [as yet unused] needed for upcoming IDB Blob support.

Source/platform/blob/BlobInfo.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.

[jsbell, 2014/03/20 16:00:46]

Use short copyright declaration

[ericu, 2014/03/25 00:00:26]

Done.

  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
  * copyright notice, this list of conditions and the following disclaimer
  * in the documentation and/or other materials provided with the
  * distribution.
  *     * Neither the name of Google Inc. nor the names of its
  * contributors may be used to endorse or promote products derived from
  * this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
  * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
  * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef V8GarbageCollected_h
-#define V8GarbageCollected_h
+#ifndef BlobInfo_h
+#define BlobInfo_h
 
-#include <v8.h>
+#include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
-template<typename T>
-class V8GarbageCollected {
-    WTF_MAKE_NONCOPYABLE(V8GarbageCollected);
+class BlobInfo {
 public:
-    static T* Cast(v8::Handle<v8::Value> value)
+    BlobInfo()
+        : m_isFile(false)
+        , m_size(-1)

[cmumford, 2014/03/20 18:22:32]

Should initialize m_lastModified.

[ericu, 2014/03/25 00:00:26]

Done.

     {
-        ASSERT(value->IsExternal());
-        T* result = static_cast<T*>(value.As<v8::External>()->Value());
-        RELEASE_ASSERT(result->m_handle == value);
-        return result;
     }
-
-protected:
-    V8GarbageCollected(v8::Isolate* isolate)
-        : m_isolate(isolate)
-        , m_handle(isolate, v8::External::New(isolate, static_cast<T*>(this)))
+    BlobInfo(const String& uuid, const String& type, long long size)
+        : m_isFile(false)
+        , m_uuid(uuid)
+        , m_type(type)
+        , m_size(size)
+        , m_lastModified(0)
+    {
+    }
+    BlobInfo(const String& uuid, const String& filePath, const String& fileName, const String& type, double lastModified, long long size)
+        : m_isFile(true)
+        , m_uuid(uuid)
+        , m_type(type)
+        , m_size(size)
+        , m_filePath(filePath)
+        , m_fileName(fileName)
+        , m_lastModified(lastModified)
+    {
+    }
+    BlobInfo(const String& uuid, const String& filePath, const String& fileName, const String& type)
+        : m_isFile(true)
+        , m_uuid(uuid)
+        , m_type(type)
+        , m_size(-1)

[jsbell, 2014/03/20 16:00:46]

Is there any consistency checking we should do when size == -1?

[ericu, 2014/03/25 00:00:26]

It's used to indicate that it's a File, but that we don't have a snapshot for it
yet.  I added an assert that it's not -1 in the Blob-type constructor.  We could
add more asserts in the accessors, but that seems a bit heavyweight.  What do
you think?

+        , m_filePath(filePath)
+        , m_fileName(fileName)
+        , m_lastModified(0)
     {
     }
 
-    v8::Handle<v8::External> releaseToV8GarbageCollector()
-    {
-        ASSERT(!m_handle.isWeak()); // Call this exactly once.
-        v8::Handle<v8::External> result = m_handle.newLocal(m_isolate);
-        m_handle.setWeak(static_cast<T*>(this), &weakCallback);
-        return result;
-    }
-
-    ~V8GarbageCollected()
-    {
-        ASSERT(m_handle.isEmpty());
-    }
-
-    v8::Isolate* isolate() { return m_isolate; }
+    bool isFile() const { return m_isFile; }
+    const String& uuid() const { return m_uuid; }
+    const String& type() const { return m_type; }
+    long long size() const { return m_size; }
+    const String& filePath() const { return m_filePath; }
+    const String& fileName() const { return m_fileName; }
+    double lastModified() const { return m_lastModified; }
 
 private:
-    static void weakCallback(const v8::WeakCallbackData<v8::External, T>& data)
-    {
-        T* self = data.GetParameter();
-        self->m_handle.clear();
-        delete self;
-    }
-
-    v8::Isolate* m_isolate;
-    ScopedPersistent<v8::External> m_handle;
+    bool m_isFile;
+    String m_uuid;
+    String m_type; // mime type

[jsbell, 2014/03/20 16:00:46]

Nit: Capitalize

[cmumford, 2014/03/20 18:22:32]

Why not call this m_MimeType instead of m_Type?

[jsbell, 2014/03/20 18:30:29]

Sorry, I meant: capitalize the comment (here and below)

No strong opinion on m_mimeType vs. just m_type; the former clarifies what it is
vs. e.g. m_isFile, but MIME has become meaningless. m_contentType would be the
pedantic form... and coincidentally that's what's used in BlobData.h FWIW.

[cmumford, 2014/03/24 23:17:46]

Well being more naive than you I'd prefer the more pedantic name, but I guess
that whatever is more consistent with current variable names is best.

[ericu, 2014/03/25 00:00:26]

Done.

I left it as type for consistency with Blob.  At some point we should probably
switch everybody over to contentType, but for now I think it's clearer to match
Blob, since it's used together in the code more than BlobData.

+    long long m_size;
+    String m_filePath; // only for File

[jsbell, 2014/03/20 16:00:46]

Nit: ditto

[ericu, 2014/03/25 00:00:26]

Done.

+    String m_fileName; // only for File
+    double m_lastModified; // only for File
 };
 
 } // namespace WebCore
 
-#endif // V8GarbageCollected_h
+#endif // BlobInfo_h